-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated scheduled tests #1846
Updated scheduled tests #1846
Conversation
…tests Signed-off-by: Nana-EC <56320167+Nana-EC@users.noreply.github.com>
…scenario Signed-off-by: Nana-EC <56320167+Nana-EC@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #1846 +/- ##
============================================
- Coverage 87.37% 87.00% -0.38%
- Complexity 1743 1745 +2
============================================
Files 315 315
Lines 7691 7731 +40
Branches 735 738 +3
============================================
+ Hits 6720 6726 +6
- Misses 744 778 +34
Partials 227 227
Continue to review full report at Codecov.
|
Signed-off-by: Nana-EC <56320167+Nana-EC@users.noreply.github.com>
...n/java/com/hedera/datagenerator/sdk/supplier/schedule/ScheduleCreateTransactionSupplier.java
Outdated
Show resolved
Hide resolved
...r-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/client/AbstractNetworkClient.java
Outdated
Show resolved
Hide resolved
...a-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/steps/ScheduleFeature.java
Outdated
Show resolved
Hide resolved
...a-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/steps/ScheduleFeature.java
Outdated
Show resolved
Hide resolved
...a-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/steps/ScheduleFeature.java
Outdated
Show resolved
Hide resolved
...a-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/client/ScheduleClient.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Nana-EC <56320167+Nana-EC@users.noreply.github.com>
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, one small nit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Scheduled transactions were updated in accordance with the [redesign](https://github.com/hashgraph/hedera-services/blob/master/docs/scheduled-transactions/revised-spec.md). This resulted in a new protobuf and a new sdk version - Pull in sdk version `2.0.5-beta.7` which uses new protobuf into data-generator, monitor and test modules - Update `ScheduleClient` to no longer sign inner transaction but outer - Update `ScheduleScenario` to handle verifications, including additional signatures that aren't required - Update monitor Schedule transaction logic - Update monitor publish logic to handle transactions with nodes set - Add HCS message publish in background to reduce likelihood of stale data Signed-off-by: Nana-EC <56320167+Nana-EC@users.noreply.github.com> Signed-off-by: Ian Jungmann <ian.jungmann@hedera.com>
Detailed description:
Scheduled transactions were updated in accordance with the redesign. This resulted in a new protobuf and a new sdk version
2.0.5-beta.7
which uses new protobuf into data-generator, monitor and test modulesScheduleClient
to no longer sign inner transaction but outerScheduleScenario
to handle verifications, including additional signatures that aren't requiredWhich issue(s) this PR fixes:
Fixes #1822
Fixes #1821
Special notes for your reviewer:
Checklist