Remove JMeter based performance tests #1981

steven-sheehy · 2021-05-16T00:33:37Z

Detailed description:

Fix acceptance test config overwriting default config
Fix monitor config documentation not showing hedera.mirror.monitor prefix and confusing users
Fix test image sometimes failing to run due to not downloading all dependencies during build
Improve test image creation time and image size (1.5GB to 566MB)
Remove all JMeter related code

Which issue(s) this PR fixes:

Special notes for your reviewer:
Follow up to #1940

Checklist

Documentation added
Tests updated

codecov · 2021-05-16T00:37:44Z

Codecov Report

Merging #1981 (7ffe95b) into master (126751e) will decrease coverage by 7.09%.
The diff coverage is 74.51%.

❗ Current head 7ffe95b differs from pull request most recent head aec542b. Consider uploading reports for the commit aec542b to get more accurate results

@@             Coverage Diff              @@
##             master    #1981      +/-   ##
============================================
- Coverage     87.05%   79.95%   -7.10%     
+ Complexity     1744      433    -1311     
============================================
  Files           315       97     -218     
  Lines          7731     2215    -5516     
  Branches        740       98     -642     
============================================
- Hits           6730     1771    -4959     
+ Misses          772      383     -389     
+ Partials        229       61     -168

Impacted Files	Coverage Δ	Complexity Δ
...ra/mirror/monitor/config/MonitorConfiguration.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
.../hedera/mirror/monitor/publish/PublishMetrics.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...a/mirror/monitor/publish/TransactionPublisher.java	`1.06% <0.00%> (-0.08%)`	`1.00 <0.00> (ø)`
...a/mirror/monitor/subscribe/AbstractSubscriber.java	`77.14% <ø> (-20.00%)`	`3.00 <0.00> (-1.00)`
.../mirror/monitor/subscribe/rest/RestSubscriber.java	`100.00% <ø> (ø)`	`22.00 <0.00> (?)`
...nitor/subscribe/rest/RestSubscriberProperties.java	`83.33% <ø> (ø)`	`4.00 <0.00> (?)`
hedera-mirror-rosetta/cmd/db.go	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...ra/mirror/monitor/subscribe/SubscribeResponse.java	`66.66% <60.00%> (ø)`	`4.00 <3.00> (?)`
hedera-mirror-rosetta/cmd/config.go	`66.66% <67.74%> (+66.66%)`	`0.00 <0.00> (ø)`
...irror/monitor/subscribe/grpc/GrpcSubscription.java	`70.00% <70.00%> (ø)`	`15.00 <15.00> (?)`
... and 240 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d5d467...aec542b. Read the comment docs.

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>

Nana-EC

Looks good.
Will circle back and signoff

Nana-EC

Looks good, some suggestions on the README

hedera-mirror-test/README.md

Nana-EC · 2021-05-17T19:11:44Z

hedera-mirror-test/README.md


-   Start the tests:
+`./mvnw clean integration-test --projects hedera-mirror-test/ -P=acceptance-tests -Dcucumber.filter.tags="@Acceptance"`


we'll remove the upper case tags soon

Suggested change

`./mvnw clean integration-test --projects hedera-mirror-test/ -P=acceptance-tests -Dcucumber.filter.tags="@Acceptance"`

`./mvnw clean integration-test --projects hedera-mirror-test/ -P=acceptance-tests -Dcucumber.filter.tags="@acceptance"`

Changed all tags in README to lowercase

Nana-EC · 2021-05-17T19:12:00Z

hedera-mirror-test/README.md


+`./mvnw clean integration-test --projects hedera-mirror-test/ -P=acceptance-tests -Dcucumber.filter.tags="@FullSuite"`


Suggested change

`./mvnw clean integration-test --projects hedera-mirror-test/ -P=acceptance-tests -Dcucumber.filter.tags="@FullSuite"`

`./mvnw clean integration-test --projects hedera-mirror-test/ -P=acceptance-tests -Dcucumber.filter.tags="@fullsuite"`

Nana-EC · 2021-05-17T19:12:08Z

hedera-mirror-test/README.md


-## Test Configuration
+`./mvnw clean integration-test --projects hedera-mirror-test/ -P=acceptance-tests -Dcucumber.filter.tags="@Negative"`


Suggested change

`./mvnw clean integration-test --projects hedera-mirror-test/ -P=acceptance-tests -Dcucumber.filter.tags="@Negative"`

`./mvnw clean integration-test --projects hedera-mirror-test/ -P=acceptance-tests -Dcucumber.filter.tags="@negative"`

Nana-EC · 2021-05-17T19:12:27Z

hedera-mirror-test/README.md


-For Subscribe Only tests no db operations are performed.
+`./mvnw clean integration-test --projects hedera-mirror-test/ -P=acceptance-tests -Dcucumber.filter.tags="@Edge"`


Suggested change

`./mvnw clean integration-test --projects hedera-mirror-test/ -P=acceptance-tests -Dcucumber.filter.tags="@Edge"`

`./mvnw clean integration-test --projects hedera-mirror-test/ -P=acceptance-tests -Dcucumber.filter.tags="@edge"`

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>

Nana-EC

LGTM

ijungmann

A couple of nits in the README, just grammar stuff, but LGTM

hedera-mirror-test/README.md

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>

sonarcloud · 2021-05-17T20:38:52Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
0.3% Duplication

Nana-EC

LGTM

* Fix acceptance test config overwriting default config * Fix monitor config documentation not showing hedera.mirror.monitor prefix and confusing users * Fix test image sometimes failing to run due to not downloading all dependencies during build * Improve test image creation time and image size (1.5GB to 566MB) * Remove all JMeter related code Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com> Signed-off-by: Ian Jungmann <ian.jungmann@hedera.com>

steven-sheehy added enhancement Type: New feature P3 performance test Test infrastructure, automated tests required, etc labels May 16, 2021

steven-sheehy added this to the Mirror 0.34.0 milestone May 16, 2021

steven-sheehy requested a review from a team May 16, 2021 00:33

steven-sheehy self-assigned this May 16, 2021

Remove JMeter based performance tests

d37aa2c

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>

steven-sheehy force-pushed the remove-jmeter branch from 9187005 to d37aa2c Compare May 16, 2021 00:45

Merge remote-tracking branch 'origin/master' into remove-jmeter

118ad98

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>

Nana-EC requested changes May 17, 2021

View reviewed changes

Nana-EC self-requested a review May 17, 2021 18:27

Nana-EC requested changes May 17, 2021

View reviewed changes

Address review feedback

5390dcb

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>

Nana-EC previously approved these changes May 17, 2021

View reviewed changes

ijungmann previously approved these changes May 17, 2021

View reviewed changes

hedera-mirror-test/README.md Outdated Show resolved Hide resolved

hedera-mirror-test/README.md Outdated Show resolved Hide resolved

hedera-mirror-test/README.md Outdated Show resolved Hide resolved

hedera-mirror-test/README.md Outdated Show resolved Hide resolved

More review feedback

aec542b

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>

steven-sheehy dismissed stale reviews from ijungmann and Nana-EC via aec542b May 17, 2021 20:34

steven-sheehy requested a review from ijungmann May 17, 2021 20:36

Nana-EC approved these changes May 17, 2021

View reviewed changes

ijungmann approved these changes May 17, 2021

View reviewed changes

steven-sheehy merged commit 65bae72 into master May 17, 2021

steven-sheehy deleted the remove-jmeter branch May 17, 2021 23:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove JMeter based performance tests #1981

Remove JMeter based performance tests #1981

steven-sheehy commented May 16, 2021 •

edited

Loading

codecov bot commented May 16, 2021 •

edited

Loading

Nana-EC left a comment •

edited

Loading

Nana-EC left a comment

Nana-EC May 17, 2021

steven-sheehy May 17, 2021

Nana-EC May 17, 2021

Nana-EC May 17, 2021

Nana-EC May 17, 2021

Nana-EC left a comment

ijungmann left a comment

sonarcloud bot commented May 17, 2021

Nana-EC left a comment


		- Start the tests:
		`./mvnw clean integration-test --projects hedera-mirror-test/ -P=acceptance-tests -Dcucumber.filter.tags="@Acceptance"`


		## Test Configuration
		`./mvnw clean integration-test --projects hedera-mirror-test/ -P=acceptance-tests -Dcucumber.filter.tags="@Negative"`


		For Subscribe Only tests no db operations are performed.
		`./mvnw clean integration-test --projects hedera-mirror-test/ -P=acceptance-tests -Dcucumber.filter.tags="@Edge"`

Remove JMeter based performance tests #1981

Remove JMeter based performance tests #1981

Conversation

steven-sheehy commented May 16, 2021 • edited Loading

codecov bot commented May 16, 2021 • edited Loading

Codecov Report

Nana-EC left a comment • edited Loading

Choose a reason for hiding this comment

Nana-EC left a comment

Choose a reason for hiding this comment

Nana-EC May 17, 2021

Choose a reason for hiding this comment

steven-sheehy May 17, 2021

Choose a reason for hiding this comment

Nana-EC May 17, 2021

Choose a reason for hiding this comment

Nana-EC May 17, 2021

Choose a reason for hiding this comment

Nana-EC May 17, 2021

Choose a reason for hiding this comment

Nana-EC left a comment

Choose a reason for hiding this comment

ijungmann left a comment

Choose a reason for hiding this comment

sonarcloud bot commented May 17, 2021

Nana-EC left a comment

Choose a reason for hiding this comment

steven-sheehy commented May 16, 2021 •

edited

Loading

codecov bot commented May 16, 2021 •

edited

Loading

Nana-EC left a comment •

edited

Loading