-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm acceptance tests #2002
Merged
Merged
Helm acceptance tests #2002
Changes from 39 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
f458dad
Initial work
11b1bb8
Fix test Dockerfile pointing to flag that does not exist (#1973)
ebfbf87
Fix service endpoint migration (#1974) (#1978)
Nana-EC 6a1a753
Signature consensus ratio config (#1950)
Nana-EC 2fd45c5
Fix using wrapper chart without redis chart enabled (#1980)
steven-sheehy ff07562
Bump grpc.version from 1.37.0 to 1.37.1 (#1987)
dependabot[bot] 70d6b56
Bump protobuf-java from 3.16.0 to 3.17.0 (#1991)
dependabot[bot] eb5e521
Bump frontend-maven-plugin from 1.11.3 to 1.12.0 (#1988)
dependabot[bot] 183f2e4
Bump software.amazon.awssdk:bom from 2.16.59 to 2.16.63 (#1990)
dependabot[bot] 3bbe810
Bump embedded.testcontainers.version from 2.0.7 to 2.0.8 (#1994)
dependabot[bot] b6a93d4
Bump jackson-dataformat-msgpack from 0.8.22 to 0.8.24 (#1995)
dependabot[bot] 7ed0efd
Bump cucumber.version from 6.10.3 to 6.10.4 (#1989)
dependabot[bot] e6ff621
Bump mathjs in /hedera-mirror-rest/monitoring/monitor_apis (#1982)
dependabot[bot] ccdd510
Bump mathjs from 9.3.2 to 9.4.0 in /hedera-mirror-rest (#1986)
dependabot[bot] 1df680a
Add alertmanager inhibit rules (#1925)
acfccd3
Remove JMeter based performance tests (#1981)
steven-sheehy 60b92cd
Fix pgpool admin password (#1998)
steven-sheehy fdbc2a4
Bump aws-sdk from 2.904.0 to 2.907.0 in /hedera-mirror-rest (#1984)
dependabot[bot] 9be6d0e
Bump eslint-plugin-import from 2.22.1 to 2.23.2 in /hedera-mirror-res…
dependabot[bot] 7c7c3e1
Add NFT Design Doc (#1845)
4616eb7
Bump versions for v0.35.0-SNAPSHOT (#1999)
hedera-github-bot dbb1d46
Add pod and secret for acceptance tests
69e3541
Cleaning up templates, adding config
a63a8a9
Change cucumber tags to template
b04ae23
Make env into volume
162878d
Fix templates
4071ea3
More template fixes
1e634a4
Stop the restart
ac97392
Add values.yaml and README
6305a3e
Fix README
ce4bc20
Fix README
5126fef
Disable test by default
0315456
Merge with master
05f9e27
Fix README
1a34249
Reorder values.yaml
8ae6a81
Change test pod name to acceptance-test
5ed0dd3
Fix rest base url
668e54c
Add retrieveAddressBook config
19175e3
Adding comments
34c0149
PR Comments
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
{{- if .Values.test.enabled -}} | ||
apiVersion: v1 | ||
kind: Pod | ||
metadata: | ||
labels: {{- include "hedera-mirror.labels" . | nindent 4 }} | ||
name: {{ include "hedera-mirror.fullname" . }}-acceptance-test | ||
namespace: {{ include "hedera-mirror.namespace" . }} | ||
annotations: | ||
helm.sh/hook: test | ||
helm.sh/hook-delete-policy: hook-failed,hook-succeeded | ||
spec: | ||
containers: | ||
- name: acceptance-tests | ||
image: "{{ .Values.test.image.repository }}:{{ .Values.test.image.tag | default .Chart.AppVersion }}" | ||
imagePullPolicy: {{ .Values.test.image.pullPolicy }} | ||
command: | ||
- 'sh' | ||
- '-c' | ||
# Copying the contents of the secret to the directory the image reads from without overwriting the existing yml. | ||
- | | ||
Nana-EC marked this conversation as resolved.
Show resolved
Hide resolved
|
||
cp /etc/secrets/* /usr/etc/hedera-mirror-node/hedera-mirror-test/src/test/resources/ | ||
./mvnw integration-test --projects hedera-mirror-test/ -P=acceptance-tests -Dcucumber.filter.tags={{ .Values.test.cucumberTags }} | ||
volumeMounts: | ||
- name: acceptance-tests | ||
mountPath: /etc/secrets | ||
readOnly: true | ||
restartPolicy: Never | ||
terminationGracePeriodSeconds: 1 | ||
volumes: | ||
- name: acceptance-tests | ||
secret: | ||
defaultMode: 420 | ||
secretName: {{ include "hedera-mirror.fullname" . }}-acceptance-test | ||
{{- end -}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
{{- if .Values.test.enabled -}} | ||
apiVersion: v1 | ||
kind: Secret | ||
metadata: | ||
labels: {{ include "hedera-mirror.labels" . | nindent 4 }} | ||
name: {{ include "hedera-mirror.fullname" . }}-acceptance-test | ||
namespace: {{ include "hedera-mirror.namespace" . }} | ||
annotations: | ||
helm.sh/hook: test | ||
helm.sh/hook-delete-policy: hook-failed,hook-succeeded | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: extra line There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed. |
||
type: Opaque | ||
stringData: | ||
# application-default.yml as application.yml will overwrite the existing yml in the hedera-mirror-test image. | ||
application-default.yml: |- | ||
{{- tpl (toYaml .Values.test.config) $ | nindent 4 }} | ||
{{- end -}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should also use the
global.image.tag
. You'll need to add aglobal.image: {}
to the values.yaml.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, added that.