Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accounts REST API with DER encoded public key #2026

Merged
merged 3 commits into from
May 27, 2021

Conversation

steven-sheehy
Copy link
Member

Detailed description:

Which issue(s) this PR fixes:
Fixes #2025

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy steven-sheehy added bug Type: Something isn't working P1 rest Area: REST API labels May 27, 2021
@steven-sheehy steven-sheehy added this to the Mirror 0.35.0 milestone May 27, 2021
@steven-sheehy steven-sheehy requested a review from a team May 27, 2021 17:17
@steven-sheehy steven-sheehy self-assigned this May 27, 2021
@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #2026 (21a87e6) into master (126751e) will decrease coverage by 7.64%.
The diff coverage is 88.15%.

❗ Current head 21a87e6 differs from pull request most recent head 78494d1. Consider uploading reports for the commit 78494d1 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2026      +/-   ##
============================================
- Coverage     87.05%   79.40%   -7.65%     
- Complexity     1744     1917     +173     
============================================
  Files           315      377      +62     
  Lines          7731     9278    +1547     
  Branches        740      870     +130     
============================================
+ Hits           6730     7367     +637     
- Misses          772     1650     +878     
- Partials        229      261      +32     
Impacted Files Coverage Δ
...sus/ConsensusSubmitMessageTransactionSupplier.java 0.00% <0.00%> (ø)
...ra/mirror/monitor/config/MonitorConfiguration.java 0.00% <0.00%> (ø)
...or/monitor/expression/ExpressionConverterImpl.java 88.88% <0.00%> (ø)
...edera/mirror/monitor/publish/PublishException.java 0.00% <0.00%> (ø)
.../hedera/mirror/monitor/publish/PublishMetrics.java 0.00% <0.00%> (ø)
...a/mirror/monitor/publish/TransactionPublisher.java 1.09% <0.00%> (-0.04%) ⬇️
...nitor/subscribe/rest/RestSubscriberProperties.java 83.33% <ø> (ø)
.../app/services/construction/construction_service.go 80.85% <ø> (-5.92%) ⬇️
...or-rosetta/app/services/mempool/mempool_service.go 100.00% <ø> (ø)
...or-rosetta/app/services/network/network_service.go 100.00% <ø> (ø)
... and 171 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c59c5c8...78494d1. Read the comment docs.

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor request, looks good otherwise

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@sonarcloud
Copy link

sonarcloud bot commented May 27, 2021

Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 83f326b into master May 27, 2021
@steven-sheehy steven-sheehy deleted the rest-der-publickey branch May 27, 2021 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working P1 rest Area: REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Account REST API doesn't support ED25519 DER encoded prefix
3 participants