-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix accounts REST API with DER encoded public key #2026
Conversation
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
Codecov Report
@@ Coverage Diff @@
## master #2026 +/- ##
============================================
- Coverage 87.05% 79.40% -7.65%
- Complexity 1744 1917 +173
============================================
Files 315 377 +62
Lines 7731 9278 +1547
Branches 740 870 +130
============================================
+ Hits 6730 7367 +637
- Misses 772 1650 +878
- Partials 229 261 +32
Continue to review full report at Codecov.
|
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor request, looks good otherwise
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Detailed description:
Which issue(s) this PR fixes:
Fixes #2025
Special notes for your reviewer:
Checklist