NFT Database Schema #2070
Merged
NFT Database Schema #2070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Jungmann <ian.jungmann@hedera.com>
ijungmann
added
database
added 2 commits
June 4, 2021 11:04
Signed-off-by: Ian Jungmann <ian.jungmann@hedera.com>
Signed-off-by: Ian Jungmann <ian.jungmann@hedera.com>
Codecov Report
@@ Coverage Diff @@
## master #2070 +/- ##
============================================
- Coverage 87.05% 79.44% -7.61%
- Complexity 1744 1919 +175
============================================
Files 315 377 +62
Lines 7731 9304 +1573
Branches 740 879 +139
============================================
+ Hits 6730 7392 +662
- Misses 772 1649 +877
- Partials 229 263 +34
Continue to review full report at Codecov.
|
Signed-off-by: Ian Jungmann <ian.jungmann@hedera.com>
ijungmann
commented
Jun 7, 2021
|
|
||
| -- Update the token table | ||
| alter table token | ||
| add column max_supply bigint not null default 9223372036854775807, |
ijungmann
commented
Jun 7, 2021
hedera-mirror-importer/src/main/resources/db/migration/v2/V2.0.0__time_scale_init.sql
Outdated
Show resolved
Hide resolved
ijungmann
commented
Jun 7, 2021
|
|
||
| -- Insert new response codes | ||
| insert into t_transaction_results (result, proto_id) | ||
| values ('ACCOUNT_EXPIRED_AND_PENDING_REMOVAL', 223), |
There was a problem hiding this comment.
This one isn't part of the NFT protobufs change, but I noticed we were missing it.
Nana-EC
requested changes
Jun 8, 2021
| alter table token | ||
| add column max_supply bigint not null default 9223372036854775807, -- max long | ||
| add column supply_type character varying(10) not null default 'INFINITE', | ||
| add column type character varying(20) not null default 'NON_FUNGIBLE_UNIQUE'; |
There was a problem hiding this comment.
I believe the default should be FUNGIBLE_COMMON
Suggested change
| add column type character varying(20) not null default 'NON_FUNGIBLE_UNIQUE'; | |
| add column type character varying(20) not null default 'FUNGIBLE_COMMON'; |
There was a problem hiding this comment.
Correct, not sure why I got that swapped. Fixed.
| ); | ||
| create unique index if not exists nft__token_id_serial_num | ||
| on nft (token_id, serial_number); | ||
| comment on table nft is 'NFT'; |
There was a problem hiding this comment.
nit: Something more suggestive. Template suggestions below that you can modify.
Suggested change
| comment on table nft is 'NFT'; | |
| comment on table nft is 'Non Fungible Tokens (NFTs) minted on network'; |
There was a problem hiding this comment.
I like that, just made Non Fungible into Non-Fungible
| symbol character varying(100) not null, | ||
| total_supply bigint not null default 0, | ||
| treasury_account_id bigint not null, | ||
| type character varying(20) not null default 'NON_FUNGIBLE_UNIQUE', |
There was a problem hiding this comment.
Same thing above, this should be FUNGIBLE_COMMON right?
Suggested change
| type character varying(20) not null default 'NON_FUNGIBLE_UNIQUE', | |
| type character varying(20) not null default 'FUNGIBLE_COMMON', |
steven-sheehy
requested changes
Jun 8, 2021
hedera-mirror-importer/src/main/resources/db/migration/v1/V1.39.0__support_nfts.sql
Outdated
Show resolved
Hide resolved
hedera-mirror-importer/src/main/resources/db/migration/v1/V1.39.0__support_nfts.sql
Outdated
Show resolved
Hide resolved
hedera-mirror-importer/src/main/resources/db/migration/v1/V1.39.0__support_nfts.sql
Outdated
Show resolved
Hide resolved
hedera-mirror-importer/src/main/resources/db/migration/v1/V1.39.0__support_nfts.sql
Outdated
Show resolved
Hide resolved
added 4 commits
June 8, 2021 17:28
Signed-off-by: Ian Jungmann <ian.jungmann@hedera.com>
Signed-off-by: Ian Jungmann <ian.jungmann@hedera.com>
|
SonarCloud Quality Gate failed. |
ijungmann
commented
Jun 8, 2021
Comment on lines
+6
to
+9
| -- Create enums for tables | ||
| CREATE TYPE token_supply_type AS ENUM ('INFINITE', 'FINITE'); | ||
| CREATE TYPE token_type AS ENUM ('FUNGIBLE_COMMON', 'NON_FUNGIBLE_UNIQUE'); | ||
|
|
There was a problem hiding this comment.
Any opinions on creating all enums at the top vs. creating them in their corresponding table sections?
There was a problem hiding this comment.
Create at top in one group as you're doing so that the data types exist prior to table definitions.
steven-sheehy
approved these changes
Jun 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description:
Add Flyway migrations to support NFTs (based on NFT design doc)
tokentable with new valuesnftandnft_transfertables, indexes, etc.Which issue(s) this PR fixes:
Fixes #2056
Special notes for your reviewer:
Checklist