Add a global hostname, pullPolicy and podAnnotations properties to chart #2073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
steven-sheehy
added
enhancement
Codecov Report
@@ Coverage Diff @@
## master #2073 +/- ##
============================================
- Coverage 87.05% 79.46% -7.60%
- Complexity 1744 1920 +176
============================================
Files 315 377 +62
Lines 7731 9304 +1573
Branches 740 879 +139
============================================
+ Hits 6730 7393 +663
- Misses 772 1649 +877
- Partials 229 262 +33
Continue to review full report at Codecov.
|
|
SonarCloud Quality Gate failed. |
ijungmann
approved these changes
Jun 7, 2021
|
|
||
| When deploying in GCP, the following steps may be taken to use container-native load balancer through |
There was a problem hiding this comment.
nit.
Suggested change
| When deploying in GCP, the following steps may be taken to use container-native load balancer through | |
| When deploying in GCP, the following steps may be taken to use a container-native load balancer through |
There was a problem hiding this comment.
Will correct in my follow up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description:
importer.addressBookproperty that takes a Base64 encoded bootstrap address book to simplify non-prod configurationglobal.hostnameproperty to simplify ingress configurationglobal.image.pullPolicypropertyglobal.podAnnotationspropertypodAnnotationsproperty to each componentWhich issue(s) this PR fixes:
Special notes for your reviewer:
A follow up PR will use the
global.podAnnotationsandglobal.image.pullPolicyto automate deployments to integration.Checklist