-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dissociate accounts from tokens post run #2090
Conversation
Signed-off-by: Nana-EC <nana.essilfie-conduah@hedera.com>
Signed-off-by: Nana-EC <nana.essilfie-conduah@hedera.com>
hedera-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/steps/TokenFeature.java
Show resolved
Hide resolved
Signed-off-by: Nana-EC <nana.essilfie-conduah@hedera.com>
Signed-off-by: Nana-EC <nana.essilfie-conduah@hedera.com>
Codecov Report
@@ Coverage Diff @@
## master #2090 +/- ##
============================================
- Coverage 87.05% 79.44% -7.61%
- Complexity 1744 1920 +176
============================================
Files 315 377 +62
Lines 7731 9304 +1573
Branches 740 879 +139
============================================
+ Hits 6730 7392 +662
- Misses 772 1649 +877
- Partials 229 263 +34
Continue to review full report at Codecov.
|
Signed-off-by: Nana-EC <nana.essilfie-conduah@hedera.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some minor issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, couple small things.
hedera-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/steps/TokenFeature.java
Show resolved
Hide resolved
...a-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/steps/ScheduleFeature.java
Show resolved
Hide resolved
Should we set the default Dockerfile command to use |
|
Signed-off-by: Nana-EC <nana.essilfie-conduah@hedera.com>
hedera-mirror-test/src/test/java/com/hedera/mirror/test/e2e/acceptance/steps/TokenFeature.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Nana-EC <nana.essilfie-conduah@hedera.com>
Signed-off-by: Nana-EC <nana.essilfie-conduah@hedera.com>
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Detailed description:
Many of the HTS acceptance tests associate the payer account with the newly created token.
Overtime this may build up and the account may hit the TOKENS_PER_ACCOUNT_LIMIT_EXCEEDED error.
Full
@acceptance
runs are also expensive and it might be worth being a bit more selective on tests included for every post deployment run@critical
and@release
flags for acceptance tests, refine tag distribution accordinglyWhich issue(s) this PR fixes:
Fixes #2069
Special notes for your reviewer:
A full
@acceptance
run was costing about 150 ℏ, with these updates I was able to cut it down to 36 ℏChecklist