Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase verify timeout to 2s in RedisEntityListenerTest #2128

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

xin-hedera
Copy link
Collaborator

@xin-hedera xin-hedera commented Jun 16, 2021

Detailed description:
Increase the timeout for CI environment.

Which issue(s) this PR fixes:
Fixes #1651

Special notes for your reviewer:
It keeps failing in my automated release PR, so it's time to take care of it...

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Xin Li <xin.li@hedera.com>
@xin-hedera xin-hedera added bug Type: Something isn't working P3 test Test infrastructure, automated tests required, etc labels Jun 16, 2021
@xin-hedera xin-hedera added this to the Mirror 0.36.0 milestone Jun 16, 2021
@xin-hedera xin-hedera self-assigned this Jun 16, 2021
@xin-hedera xin-hedera requested a review from a team June 16, 2021 21:48
@xin-hedera xin-hedera marked this pull request as ready for review June 16, 2021 21:48
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #2128 (174ef54) into master (126751e) will decrease coverage by 6.27%.
The diff coverage is 93.23%.

❗ Current head 174ef54 differs from pull request most recent head d46cc3b. Consider uploading reports for the commit d46cc3b to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2128      +/-   ##
============================================
- Coverage     87.05%   80.77%   -6.28%     
- Complexity     1744     2065     +321     
============================================
  Files           315      406      +91     
  Lines          7731    10801    +3070     
  Branches        740      892     +152     
============================================
+ Hits           6730     8725    +1995     
- Misses          772     1773    +1001     
- Partials        229      303      +74     
Impacted Files Coverage Δ
...ensus/ConsensusCreateTopicTransactionSupplier.java 0.00% <ø> (ø)
...sus/ConsensusSubmitMessageTransactionSupplier.java 0.00% <0.00%> (ø)
...ensus/ConsensusUpdateTopicTransactionSupplier.java 0.00% <ø> (ø)
...er/schedule/ScheduleCreateTransactionSupplier.java 0.00% <ø> (ø)
...supplier/token/TokenCreateTransactionSupplier.java 0.00% <ø> (ø)
...supplier/token/TokenUpdateTransactionSupplier.java 0.00% <ø> (ø)
...era/mirror/importer/config/CacheConfiguration.java 100.00% <ø> (ø)
.../hedera/mirror/importer/domain/AccountBalance.java 84.61% <ø> (ø)
...era/mirror/importer/domain/AccountBalanceFile.java 94.73% <ø> (ø)
...va/com/hedera/mirror/importer/domain/EntityId.java 95.65% <ø> (ø)
... and 268 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93196fc...d46cc3b. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jun 16, 2021

@xin-hedera xin-hedera merged commit d897f05 into master Jun 16, 2021
@xin-hedera xin-hedera deleted the fix-RedisEntityListenerTest-onSlowPublish branch June 16, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working P3 test Test infrastructure, automated tests required, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RedisEntityListenerTest.onSlowPublish failed in github action
3 participants