Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a PodDisruptionBudget to gRPC and REST #2138

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Conversation

steven-sheehy
Copy link
Member

Detailed description:

  • Add a PodDisruptionBudget to gRPC chart
  • Add a PodDisruptionBudget to REST chart
  • Enable gRPC HPA with a min replicas of 2 for production
  • Enable PodDisruptionBudget by default for production
  • Fix PodDisruptionBudget not allowing percentage values

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy steven-sheehy added enhancement Type: New feature P2 process Build or test related tasks labels Jun 17, 2021
@steven-sheehy steven-sheehy requested a review from a team June 17, 2021 21:29
@steven-sheehy steven-sheehy self-assigned this Jun 17, 2021
@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #2138 (6cf462f) into master (0000d7b) will increase coverage by 23.75%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #2138       +/-   ##
=============================================
+ Coverage     57.92%   81.68%   +23.75%     
- Complexity        0     2115     +2115     
=============================================
  Files            56      410      +354     
  Lines          2491    10871     +8380     
  Branches        325      899      +574     
=============================================
+ Hits           1443     8880     +7437     
- Misses          903     1681      +778     
- Partials        145      310      +165     
Impacted Files Coverage Δ
...n/java/com/hedera/datagenerator/DataGenerator.java 0.00% <ø> (ø)
...dera/datagenerator/DataGeneratorConfiguration.java 0.00% <ø> (ø)
.../hedera/datagenerator/DataGeneratorProperties.java 0.00% <ø> (ø)
...agenerator/common/CryptoTransactionProperties.java 0.00% <ø> (ø)
...com/hedera/datagenerator/common/EntityManager.java 0.00% <ø> (ø)
...atagenerator/common/FileTransactionProperties.java 0.00% <ø> (ø)
...tagenerator/common/TopicTransactionProperties.java 0.00% <ø> (ø)
...era/datagenerator/common/TransactionGenerator.java 0.00% <ø> (ø)
...nerator/common/TransactionGeneratorProperties.java 0.00% <ø> (ø)
.../java/com/hedera/datagenerator/common/Utility.java 86.95% <ø> (ø)
... and 507 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d08f61f...6cf462f. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jun 17, 2021

Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy added this to the Mirror 0.36.0 milestone Jun 18, 2021
Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit cf067eb into master Jun 21, 2021
@steven-sheehy steven-sheehy deleted the poddisruptionbudget branch June 21, 2021 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature P2 process Build or test related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants