Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase RedisEntityListenerTest.onSlowPublish timeout #2152

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

steven-sheehy
Copy link
Member

Detailed description:
Increase RedisEntityListenerTest.onSlowPublish timeouts even further since it still fails in CI

Which issue(s) this PR fixes:
Fixes #1651

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy steven-sheehy added bug Type: Something isn't working test Test infrastructure, automated tests required, etc labels Jun 21, 2021
@steven-sheehy steven-sheehy added this to the Mirror 0.36.0 milestone Jun 21, 2021
@steven-sheehy steven-sheehy requested a review from a team June 21, 2021 15:34
@steven-sheehy steven-sheehy self-assigned this Jun 21, 2021
@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #2152 (78979fb) into master (0000d7b) will increase coverage by 31.25%.
The diff coverage is n/a.

❗ Current head 78979fb differs from pull request most recent head 3ad4c55. Consider uploading reports for the commit 3ad4c55 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             master    #2152       +/-   ##
=============================================
+ Coverage     57.92%   89.18%   +31.25%     
- Complexity        0     1606     +1606     
=============================================
  Files            56      199      +143     
  Lines          2491     4437     +1946     
  Branches        325      402       +77     
=============================================
+ Hits           1443     3957     +2514     
+ Misses          903      291      -612     
- Partials        145      189       +44     
Impacted Files Coverage Δ
...era/mirror/importer/MirrorImporterApplication.java 33.33% <ø> (ø)
...a/com/hedera/mirror/importer/MirrorProperties.java 96.15% <ø> (+3.29%) ⬆️
...r/importer/addressbook/AddressBookServiceImpl.java 89.56% <ø> (ø)
...importer/parser/record/RecordParserProperties.java 50.00% <0.00%> (-42.31%) ⬇️
...dera/mirror/importer/domain/TransactionResult.java 33.33% <0.00%> (-33.34%) ⬇️
.../com/hedera/mirror/importer/domain/EntityType.java 0.00% <0.00%> (-33.34%) ⬇️
...mporter/downloader/CommonDownloaderProperties.java 76.00% <0.00%> (-17.75%) ⬇️
.../com/hedera/mirror/importer/domain/StreamType.java 91.17% <0.00%> (-8.83%) ⬇️
...com/hedera/mirror/importer/domain/Transaction.java 80.95% <0.00%> (-6.55%) ⬇️
...r/importer/parser/event/EventParserProperties.java 80.00% <0.00%> (-5.72%) ⬇️
... and 217 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e84cafc...3ad4c55. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2021

Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 125f1d1 into master Jun 21, 2021
@steven-sheehy steven-sheehy deleted the onslowpublish branch June 21, 2021 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working test Test infrastructure, automated tests required, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RedisEntityListenerTest.onSlowPublish failed in github action
3 participants