Add multi batch support to upsert pgcopy flow to release 0.36 #2155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nana-EC <nana.essilfie-conduah@hedera.com>
Codecov Report
@@ Coverage Diff @@
## release/0.36 #2155 +/- ##
===============================================
Coverage 81.70% 81.70%
Complexity 2114 2114
===============================================
Files 410 410
Lines 10940 10944 +4
Branches 922 922
===============================================
+ Hits 8938 8942 +4
Misses 1691 1691
Partials 311 311
Continue to review full report at Codecov.
|
|
SonarCloud Quality Gate failed. |
steven-sheehy
approved these changes
Jun 21, 2021
Nana-EC
added a commit
that referenced
this pull request
Jun 23, 2021
When batch inserts occur within the same record file the Upsert flow attempt to recreate the temporary table that already exists - Update Create table query to with `if not exists` - Add a `truncate table` regardless to ensure insert and update don't utilize previously inserted information Cherry pick of [PR 2153](#2153) Signed-off-by: Nana-EC <nana.essilfie-conduah@hedera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description:
When batch inserts occur within the same record file the Upsert flow attempt to recreate the temporary table that already exists
if not existstruncate tableregardless to ensure insert and update don't utilize previously inserted informationCherry pick of PR 2153
Which issue(s) this PR fixes:
Fixes #2154
Special notes for your reviewer:
Checklist