Deduplicate NFT transfers #2164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nana-EC <nana.essilfie-conduah@hedera.com>
Codecov Report
@@ Coverage Diff @@
## main #2164 +/- ##
=======================================
Coverage ? 81.72%
Complexity ? 2135
=======================================
Files ? 412
Lines ? 10982
Branches ? 931
=======================================
Hits ? 8975
Misses ? 1695
Partials ? 312 Continue to review full report at Codecov.
|
steven-sheehy
changed the title
steven-sheehy
previously approved these changes
Jun 23, 2021
xin-hedera
requested changes
Jun 23, 2021
Signed-off-by: Nana-EC <nana.essilfie-conduah@hedera.com>
|
SonarCloud Quality Gate failed. |
ijungmann
approved these changes
Jun 23, 2021
steven-sheehy
approved these changes
Jun 23, 2021
Nana-EC
added a commit
that referenced
this pull request
Jun 23, 2021
* Deduplicate nft trasnfers list
A duplicate nft transfer entry exists when the /api/v1/transactions?account.id={account} is called and the account in question is the recipient.
- Update aggregation to use `distinct jsonb_build_object`
- Add an extra test for multiple nft transfers across different tokens in one transaction
Signed-off-by: Nana-EC <nana.essilfie-conduah@hedera.com>
Nana-EC
added a commit
that referenced
this pull request
Jun 24, 2021
* Deduplicate nft trasnfers list
Cherry pick Deduplicate nft trasnfers list
A duplicate nft transfer entry exists when the /api/v1/transactions?account.id={account} is called and the account in question is the recipient.
- Update aggregation to use `distinct jsonb_build_object`
- Add an extra test for multiple nft transfers across different tokens in one transaction
Signed-off-by: Nana-EC <nana.essilfie-conduah@hedera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description:
A duplicate nft transfer entry exists when the /api/v1/transactions?account.id={account} is called and the account in question is the recipient.
distinct jsonb_build_objectWhich issue(s) this PR fixes:
Fixes #2139
Special notes for your reviewer:
Postgres doesn't support distinct and order by for json. This should be okay though as the rows are mostly ordered prior to aggregation
Checklist