Custom fees support design #2173
Conversation
Signed-off-by: Xin Li <xin.li@hedera.com>
Signed-off-by: Xin Li <xin.li@hedera.com>
xin-hedera
added
enhancement
Codecov Report
@@ Coverage Diff @@
## main #2173 +/- ##
=======================================
Coverage ? 81.69%
Complexity ? 2134
=======================================
Files ? 414
Lines ? 11150
Branches ? 945
=======================================
Hits ? 9109
Misses ? 1732
Partials ? 309 Continue to review full report at Codecov.
|
Signed-off-by: Xin Li <xin.li@hedera.com>
Signed-off-by: Xin Li <xin.li@hedera.com>
Signed-off-by: Xin Li <xin.li@hedera.com>
Signed-off-by: Xin Li <xin.li@hedera.com>
Signed-off-by: Xin Li <xin.li@hedera.com>
docs/design/custom-fees.md
Outdated
| amount bigint not null, | ||
| amount_denominator bigint, | ||
| collector_account_id bigint, | ||
| created_timestamp bigint not null, |
There was a problem hiding this comment.
renamed it from consensus_timestamp, created better describes the field and also in the token info json response, created_timestamp is easier to understand and more distinguishable when it's mixed with the token's created and modified timestamp.
Signed-off-by: Xin Li <xin.li@hedera.com>
|
moved it back to draft since there will be incompatible changes in protobufs for HIP-18. |
Signed-off-by: Xin Li <xin.li@hedera.com>
Signed-off-by: Xin Li <xin.li@hedera.com>
Signed-off-by: Xin Li <xin.li@hedera.com>
| collector_account_id bigint, | ||
| created_timestamp bigint not null, | ||
| denominating_token_id bigint, | ||
| maximum_amount bigint, |
There was a problem hiding this comment.
removed has_custom_fee
|
SonarCloud Quality Gate failed. |
- Add HTS custom fees design doc Signed-off-by: Xin Li <xin.li@hedera.com> Signed-off-by: Ian Jungmann <ian.jungmann@hedera.com>
Detailed description:
This is just for the design review.
Which issue(s) this PR fixes:
Relates to #2166
Special notes for your reviewer:
This is the hedera-protobufs custom fees PR (hashgraph/hedera-protobufs#42).
Update: the protobufs PR is merged and made into Hedera protobufs v0.16.0-alpha.1 release.
Checklist