Remove GitHub docs in favor of organization level configuration #2210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
steven-sheehy
added
documentation
Codecov Report
@@ Coverage Diff @@
## main #2210 +/- ##
=======================================
Coverage ? 76.57%
Complexity ? 530
=======================================
Files ? 214
Lines ? 6667
Branches ? 543
=======================================
Hits ? 5105
Misses ? 1438
Partials ? 124 Continue to review full report at Codecov.
|
Nana-EC
reviewed
Jun 30, 2021
docs/configuration.md
Outdated
| default**. | ||
| ## Default Values | ||
|
|
||
| The default configuration allows users to get quickly up and running without having to configure anything. This provides |
There was a problem hiding this comment.
nit: reads better I think
Suggested change
| The default configuration allows users to get quickly up and running without having to configure anything. This provides | |
| The default configuration allows users to quickly get up and running without having to configure anything. This provides |
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
|
SonarCloud Quality Gate failed. |
|
I ended up being able to add the link to HIP in the organization level config. So no changes necessary here for that. |
ijungmann
pushed a commit
that referenced
this pull request
Jul 16, 2021
* Add a issue template config.yml since discussions link is project specific * Add documentation on use of passwords * Fix a line rendering error in deployment diagram * Remove GitHub docs in favor of organization level configuration Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com> Signed-off-by: Ian Jungmann <ian.jungmann@hedera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description:
Which issue(s) this PR fixes:
Special notes for your reviewer:
CONTRIBUTING.md PR still up for review.
Checklist