Custom fees REST api #2247
Merged
Custom fees REST api #2247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xin Li <xin.li@hedera.com>
Signed-off-by: Xin Li <xin.li@hedera.com>
Signed-off-by: Xin Li <xin.li@hedera.com>
Signed-off-by: Xin Li <xin.li@hedera.com>
Signed-off-by: Xin Li <xin.li@hedera.com>
Signed-off-by: Xin Li <xin.li@hedera.com>
Codecov Report
@@ Coverage Diff @@
## main #2247 +/- ##
============================================
+ Coverage 83.13% 83.27% +0.13%
Complexity 2234 2234
============================================
Files 433 437 +4
Lines 11682 11783 +101
Branches 985 1002 +17
============================================
+ Hits 9712 9812 +100
- Misses 1642 1643 +1
Partials 328 328
Continue to review full report at Codecov.
|
xin-hedera
commented
Jul 8, 2021
xin-hedera
commented
Jul 8, 2021
Signed-off-by: Xin Li <xin.li@hedera.com>
Signed-off-by: Xin Li <xin.li@hedera.com>
xin-hedera
commented
Jul 8, 2021
Comment on lines
+184
to
+185
| logger.error(err); | ||
| process.exit(1); |
There was a problem hiding this comment.
rethrow will cause unhandled rejection warning and the nodejs process hanging there.
Signed-off-by: Xin Li <xin.li@hedera.com>
Nana-EC
requested changes
Jul 8, 2021
Signed-off-by: Xin Li <xin.li@hedera.com>
xin-hedera
commented
Jul 8, 2021
| 'maximum_amount', ${CustomFee.MAXIMUM_AMOUNT}::text, | ||
| 'minimum_amount', ${CustomFee.MINIMUM_AMOUNT}::text, | ||
| 'token_id', ${CustomFee.TOKEN_ID}::text | ||
| ) order by ${CustomFee.AMOUNT}, ${CustomFee.COLLECTOR_ACCOUNT_ID}, ${CustomFee.DENOMINATING_TOKEN_ID}) |
There was a problem hiding this comment.
order the custom fees so integration tests can pass. it's interesting that the same data inserted in the same order, vanilla pg and timescaledb return them in opposite orders.
There was a problem hiding this comment.
Probably cause of the extra index in the timescale case
steven-sheehy
requested changes
Jul 8, 2021
hedera-mirror-rest/__tests__/specs/token-info-05-custom-fees.spec.json
Outdated
Show resolved
Hide resolved
hedera-mirror-rest/__tests__/specs/token-info-05-custom-fees.spec.json
Outdated
Show resolved
Hide resolved
hedera-mirror-rest/__tests__/specs/token-info-05-custom-fees.spec.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Xin Li <xin.li@hedera.com>
|
SonarCloud Quality Gate failed. |
ijungmann
approved these changes
Jul 9, 2021
ijungmann
pushed a commit
that referenced
this pull request
Jul 16, 2021
- Add assessed custom fees to /api/v1/transactions/:transactionId endpoint - Add custom fees schedule to/api/v1/tokens/:tokenId endpoint - Add model/viewmodel for assessed custom fees and custom fees schedule - Add integration domain support for assessed custom fees and custom fees schedule - Update openapi spec - Fix EntityId throwing exception with nullable undefined value - Move queryQuietly to pool class prototype - Add/Update integration tests Signed-off-by: Xin Li <xin.li@hedera.com> Signed-off-by: Ian Jungmann <ian.jungmann@hedera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds HTS custom fees support to the mirror node REST API.
/api/v1/transactions/:transactionIdendpoint/api/v1/tokens/:tokenIdendpointundefinedvaluequeryQuietlyto pool class prototypeRelated issue(s):
Fixes #2199
Notes for reviewer:
Checklist