Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a platform not active alert #2281

Merged
merged 4 commits into from
Jul 16, 2021
Merged

Add a platform not active alert #2281

merged 4 commits into from
Jul 16, 2021

Conversation

steven-sheehy
Copy link
Member

@steven-sheehy steven-sheehy commented Jul 15, 2021

Description:

  • Add a platform not active alert and inhibit all other application alerts when active
  • Change balance alert back to 15 min to reflect adjustment in main node
  • Change GrpcClientSDKTest to in-process channel to reduce flaky tests
  • Disable kube API server and kube DNS metric exporters to reduce overall time series count
  • Fix monitor showing a generic Exception publish error by getting root throwable
  • Fix monitor interval rate calculation by using Micrometer utility
  • Fix use of deprecated Flux::limitRequest
  • Increase monitor publish error alert threshold

Related issue(s):

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@steven-sheehy steven-sheehy added enhancement Type: New feature P2 monitor Area: Monitoring and dashboard labels Jul 15, 2021
@steven-sheehy steven-sheehy added this to the Mirror 0.38.0 milestone Jul 15, 2021
@steven-sheehy steven-sheehy requested a review from a team July 15, 2021 23:09
@steven-sheehy steven-sheehy self-assigned this Jul 15, 2021
@codecov
Copy link

codecov bot commented Jul 15, 2021

Codecov Report

Merging #2281 (1b1c5a7) into main (1552d20) will increase coverage by 0.00%.
The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #2281   +/-   ##
=========================================
  Coverage     83.48%   83.49%           
+ Complexity     2234     2231    -3     
=========================================
  Files           437      437           
  Lines         11998    11990    -8     
  Branches       1002     1001    -1     
=========================================
- Hits          10017    10011    -6     
  Misses         1653     1653           
+ Partials        328      326    -2     
Impacted Files Coverage Δ
...om/hedera/mirror/monitor/MirrorNodeProperties.java 47.36% <50.00%> (-5.58%) ⬇️
...a/mirror/grpc/service/TopicMessageServiceImpl.java 88.00% <100.00%> (ø)
.../hedera/mirror/monitor/publish/PublishMetrics.java 86.51% <100.00%> (+1.73%) ⬆️
...mirror/monitor/subscribe/AbstractSubscription.java 82.85% <100.00%> (+1.90%) ⬆️
...irror/monitor/subscribe/grpc/GrpcSubscription.java 96.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eae922...1b1c5a7. Read the comment docs.

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
ijungmann
ijungmann previously approved these changes Jul 16, 2021
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
xin-hedera
xin-hedera previously approved these changes Jul 16, 2021
Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nana-EC
Nana-EC previously approved these changes Jul 16, 2021
Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy steven-sheehy dismissed stale reviews from Nana-EC and xin-hedera via 1b1c5a7 July 16, 2021 18:44
@sonarcloud
Copy link

sonarcloud bot commented Jul 16, 2021

Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit ae4d0c8 into main Jul 16, 2021
@steven-sheehy steven-sheehy deleted the monitor-alerts branch July 16, 2021 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature monitor Area: Monitoring and dashboard P2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants