Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stream file health check in Kubernetes #2301

Merged
merged 1 commit into from
Jul 20, 2021
Merged

Conversation

steven-sheehy
Copy link
Member

@steven-sheehy steven-sheehy commented Jul 19, 2021

Description:

  • Fix stream file health check when used in Kubernetes
  • Fix chart install action not using locally built image
  • Move some cloud storage Java config to specific config class

Related issue(s):

Fixes #2289

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@steven-sheehy steven-sheehy added bug Type: Something isn't working P1 labels Jul 19, 2021
@steven-sheehy steven-sheehy added this to the Mirror 0.38.0 milestone Jul 19, 2021
@steven-sheehy steven-sheehy self-assigned this Jul 19, 2021
@codecov
Copy link

codecov bot commented Jul 19, 2021

Codecov Report

Merging #2301 (a0d0620) into main (36e8be0) will increase coverage by 0.03%.
The diff coverage is 73.07%.

❗ Current head a0d0620 differs from pull request most recent head 60943b2. Consider uploading reports for the commit 60943b2 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2301      +/-   ##
============================================
+ Coverage     83.49%   83.53%   +0.03%     
- Complexity     2232     2236       +4     
============================================
  Files           437      437              
  Lines         11992    12001       +9     
  Branches       1000     1001       +1     
============================================
+ Hits          10013    10025      +12     
+ Misses         1653     1652       -1     
+ Partials        326      324       -2     
Impacted Files Coverage Δ
...om/hedera/mirror/importer/leader/LeaderAspect.java 0.00% <0.00%> (ø)
...ror/importer/config/CloudStorageConfiguration.java 65.78% <65.78%> (ø)
...rror/importer/config/HealthCheckConfiguration.java 100.00% <100.00%> (ø)
...r/importer/config/MirrorImporterConfiguration.java 52.94% <100.00%> (-7.53%) ⬇️
...ror/importer/config/StreamFileHealthIndicator.java 100.00% <100.00%> (ø)
...mporter/downloader/CommonDownloaderProperties.java 80.00% <0.00%> (+4.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36e8be0...60943b2. Read the comment docs.

@steven-sheehy steven-sheehy marked this pull request as draft July 19, 2021 18:50
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2021

@steven-sheehy steven-sheehy marked this pull request as ready for review July 19, 2021 22:36
@steven-sheehy steven-sheehy requested a review from a team July 19, 2021 22:36
Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 8751d87 into main Jul 20, 2021
@steven-sheehy steven-sheehy deleted the fix-stream-health branch July 20, 2021 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working P1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StreamFileHealthIndicator causes issue in k8s
4 participants