Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Sonar & Rosetta validate on push to main #2315

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Conversation

steven-sheehy
Copy link
Member

Description:

  • Fix SonarCloud check not running on push to main or release branches
  • Fix Rosetta validate check not running on push to main or release branches

Related issue(s):

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@steven-sheehy steven-sheehy added bug Type: Something isn't working P3 process Build or test related tasks labels Jul 23, 2021
@steven-sheehy steven-sheehy added this to the Mirror 0.37.2 milestone Jul 23, 2021
@steven-sheehy steven-sheehy self-assigned this Jul 23, 2021
@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #2315 (d23535a) into main (8927283) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #2315   +/-   ##
=========================================
  Coverage     83.23%   83.23%           
  Complexity     2242     2242           
=========================================
  Files           438      438           
  Lines         12070    12070           
  Branches       1015     1015           
=========================================
  Hits          10046    10046           
  Misses         1698     1698           
  Partials        326      326           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8927283...d23535a. Read the comment docs.

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 23, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@steven-sheehy steven-sheehy marked this pull request as ready for review July 23, 2021 19:41
@steven-sheehy steven-sheehy requested a review from a team July 23, 2021 19:42
@steven-sheehy steven-sheehy merged commit 46e8116 into main Jul 23, 2021
@steven-sheehy steven-sheehy deleted the sonar-main branch July 23, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working P3 process Build or test related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants