Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix address_book_entry table update on compressed chunk issue #2318

Merged
merged 1 commit into from
Jul 24, 2021

Conversation

xin-hedera
Copy link
Collaborator

Description:

This PR fixes the address_book_entry update on compressed timescaledb chunk issue.

  • Change address book related tables to be vanilla postgres tables
  • Upgrade to pg13.3-ts2.3.1-p1 image

Related issue(s):

Fixes #

Notes for reviewer:

Update data in compressed chunks is not allowed. In addition, there is no benefit in making the address book tables hypertables, taken how small those tables are and how infrequently they get updates.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

… images

Signed-off-by: Xin Li <xin.li@hedera.com>
@xin-hedera xin-hedera added bug Type: Something isn't working P3 database Area: Database labels Jul 23, 2021
@xin-hedera xin-hedera added this to the Mirror 0.37.2 milestone Jul 23, 2021
@xin-hedera xin-hedera requested a review from a team July 23, 2021 21:05
@xin-hedera xin-hedera self-assigned this Jul 23, 2021
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #2318 (ade6bd7) into main (8927283) will not change coverage.
The diff coverage is n/a.

❗ Current head ade6bd7 differs from pull request most recent head 6f525d6. Consider uploading reports for the commit 6f525d6 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##               main    #2318   +/-   ##
=========================================
  Coverage     83.23%   83.23%           
  Complexity     2242     2242           
=========================================
  Files           438      438           
  Lines         12070    12070           
  Branches       1015     1015           
=========================================
  Hits          10046    10046           
  Misses         1698     1698           
  Partials        326      326           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8927283...6f525d6. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jul 23, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xin-hedera xin-hedera merged commit e9273ee into main Jul 24, 2021
@xin-hedera xin-hedera deleted the fix-address-book-entry-tsdb-compression-issue branch July 24, 2021 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working database Area: Database P3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants