Add a cluster health endpoint to monitor #2353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
steven-sheehy
added
bug
Codecov Report
@@ Coverage Diff @@
## main #2353 +/- ##
============================================
+ Coverage 83.59% 84.38% +0.78%
- Complexity 2258 2313 +55
============================================
Files 437 440 +3
Lines 11961 12002 +41
Branches 1018 1020 +2
============================================
+ Hits 9999 10128 +129
+ Misses 1647 1556 -91
- Partials 315 318 +3
Continue to review full report at Codecov.
|
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
Nana-EC
reviewed
Aug 3, 2021
Nana-EC
requested changes
Aug 3, 2021
hedera-mirror-monitor/src/main/java/com/hedera/mirror/monitor/ClusterHealthIndicator.java
Show resolved
Hide resolved
hedera-mirror-monitor/src/main/java/com/hedera/mirror/monitor/ClusterHealthIndicator.java
Show resolved
Hide resolved
hedera-mirror-monitor/src/main/java/com/hedera/mirror/monitor/NodeProperties.java
Show resolved
Hide resolved
ijungmann
suggested changes
Aug 3, 2021
| @Validated | ||
| public static class RetryProperties { | ||
|
|
||
| @Min(0) |
There was a problem hiding this comment.
Minimum should be 1, setting to 0 will never attempt.
There was a problem hiding this comment.
True, but Flux retry spec uses this as the "retry attempts" not total attempts like the SDK so it needs to remain 0 here. I can add an assertion in ConfigurableTransactionGenerator that validates it.
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Nana-EC
approved these changes
Aug 3, 2021
ijungmann
approved these changes
Aug 3, 2021
steven-sheehy
added a commit
that referenced
this pull request
Aug 10, 2021
Adds a cluster health endpoint to monitor and fixes various bugs with the monitor encountered during testing. * Add an /actuator/health/cluster endpoint that returns unknown when publishing inactive * Add transaction memo with hostname & scenario to track publish source * Add new previewnet node 0.0.7 * Add support for in-process testing of TransactionPublisher * Change mainnet network configuration to use mainnet-public * Fix MonitorPublishErrors alert not calculating percentage properly and triggering repeatedly * Fix node validation succeeding when network is frozen by switching from a query to a transaction * Fix not printing status logs or sampling when scenario is idle * Fix rate calculation sometimes returning 0.0 at low TPS * Fix publish properties failing on unknown properties (this allows camelcase properties to be supplied via env variables) * Fix transaction record lookup doing 3 separate queries * Refactor publish flow to store scenario state in new PublishScenario * Refactor publish & subscribe flows to use common scenario and scenario properties classes * Refactor publish client setup to use Flux Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds a cluster health endpoint to monitor and fixes various bugs with the monitor encountered during testing.
/actuator/health/clusterendpoint that returns unknown when publishing inactive0.0.7TransactionPublisherMonitorPublishErrorsalert not calculating percentage properly and triggering repeatedlyPublishScenarioRelated issue(s):
Fixes #2313
Notes for reviewer:
Waiting on access to perfnet to test changes at 10K.
Will keep subscriber REST API for now to ease rollout. May delete it later.
Checklist