Fix incorrect fixed fee denominating token id #2358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xin Li <xin.li@hedera.com>
xin-hedera
added
bug
Codecov Report
@@ Coverage Diff @@
## main #2358 +/- ##
=========================================
Coverage 83.59% 83.59%
- Complexity 2257 2259 +2
=========================================
Files 437 437
Lines 11961 11963 +2
Branches 1018 1020 +2
=========================================
+ Hits 9999 10001 +2
Misses 1647 1647
Partials 315 315
Continue to review full report at Codecov.
|
Nana-EC
previously approved these changes
Aug 3, 2021
.../src/main/java/com/hedera/mirror/importer/parser/record/entity/EntityRecordItemListener.java
Show resolved
Hide resolved
.../src/main/java/com/hedera/mirror/importer/parser/record/entity/EntityRecordItemListener.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Xin Li <xin.li@hedera.com>
|
Kudos, SonarCloud Quality Gate passed!
|
xin-hedera
added a commit
that referenced
this pull request
Aug 3, 2021
- Set the denominating token id of a fixed fee to the attached token id when it's the sentinel token 0.0.0 Signed-off-by: Xin Li <xin.li@hedera.com>
xin-hedera
added a commit
that referenced
this pull request
Aug 9, 2021
- Set the denominating token id of a fixed fee to the attached token id when it's the sentinel token 0.0.0 Signed-off-by: Xin Li <xin.li@hedera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
0.0.0Related issue(s):
Fixes #2357
Notes for reviewer:
Please refer to the ticket for the context.
Checklist