Address info level code smells #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steven-sheehy
added
enhancement
steven-sheehy
changed the title
Codecov Report
@@ Coverage Diff @@
## main #2361 +/- ##
=========================================
Coverage 84.38% 84.39%
+ Complexity 2315 2308 -7
=========================================
Files 440 439 -1
Lines 12004 11977 -27
Branches 1022 1020 -2
=========================================
- Hits 10130 10108 -22
+ Misses 1556 1551 -5
Partials 318 318 Continue to review full report at Codecov.
|
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
steven-sheehy
force-pushed
the
code-smells-info
branch
from
e27053a
to
edc8456
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Nana-EC
approved these changes
Aug 5, 2021
ijungmann
approved these changes
Aug 6, 2021
steven-sheehy
added a commit
that referenced
this pull request
Aug 10, 2021
* Fix info level code smells * Remove unused REST API performance tests * Remove unused TimestampConverter Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
TimestampConverterRelated issue(s):
Fixes #2336
Notes for reviewer:
There was one info code smell for perf test. Instead of fixing I just removed the whole folder 😄 . But we don't use the REST API performance and we rely on k6 tests now anyway.
Checklist