Change schedule primary key from consensus_timestamp to schedule_id #2382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2382 +/- ##
============================================
- Coverage 84.35% 84.35% -0.01%
- Complexity 2308 2309 +1
============================================
Files 439 439
Lines 11982 11984 +2
Branches 1020 1020
============================================
+ Hits 10108 10109 +1
Misses 1556 1556
- Partials 318 319 +1
Continue to review full report at Codecov.
|
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
steven-sheehy
force-pushed
the
schedule-primary-key
branch
from
92872cf
to
b560191
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Nana-EC
reviewed
Aug 9, 2021
| on schedule (schedule_id desc, consensus_timestamp desc); | ||
|
|
||
| alter table if exists schedule | ||
| add primary key (schedule_id); |
There was a problem hiding this comment.
We may be missing a REST endpoint for filter by timestamp, which is where an additional timestamp index might be useful to speed up queries.
We can address that later though
ijungmann
approved these changes
Aug 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue(s):
Fixes #2380
Notes for reviewer:
Checklist