Improve monitor startup performance (0.38.1) #2397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve monitor startup performance by moving publish and subscribe flow initialization off main thread * Increase node validation timeout to 30s * Adjust monitor probe delay to reflect startup improvement Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
steven-sheehy
added
bug
steven-sheehy
changed the title
Codecov Report
@@ Coverage Diff @@
## release/0.38 #2397 +/- ##
==================================================
- Coverage 84.35% 84.32% -0.04%
+ Complexity 2309 2308 -1
==================================================
Files 439 439
Lines 11982 11983 +1
Branches 1020 1020
==================================================
- Hits 10108 10105 -3
- Misses 1556 1560 +4
Partials 318 318
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
Nana-EC
approved these changes
Aug 11, 2021
| @@ -186,8 +186,8 @@ private boolean validateNode(Client client, NodeProperties node) { | |||
| new TransferTransaction() | |||
| .addHbarTransfer(nodeAccountId, hbar) | |||
| .addHbarTransfer(client.getOperatorAccountId(), hbar.negated()) | |||
| .execute(client, Duration.ofSeconds(10L)) | |||
| .getReceipt(client, Duration.ofSeconds(10L)); | |||
| .execute(client, Duration.ofSeconds(30L)) | |||
There was a problem hiding this comment.
nit: if you circle - move to shared constant.
Meant to say this in main before you merged.
ijungmann
approved these changes
Aug 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue(s):
Notes for reviewer:
Cherry pick of #2395 to 0.38.1
Checklist