Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main to release/0.39 #2441

Merged
merged 6 commits into from
Aug 23, 2021
Merged

Merge main to release/0.39 #2441

merged 6 commits into from
Aug 23, 2021

Conversation

steven-sheehy
Copy link
Member

Description:

Related issue(s):

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Ian Jungmann and others added 6 commits August 18, 2021 15:21
* Remove the data generator module and all references to it.
* Move TransactionSuppliers and anything else needed by the monitor into the monitor module
* Add unit tests for the TransactionSuppliers

Signed-off-by: Ian Jungmann <ian.jungmann@hedera.com>
* Fix startDate logic on empty DB

The current MirrorDateRangePropertiesProcessor.newDateRangeFilter() currently doesn't honor the startDate set on an empty db

- Update newDateRangeFilter() logic to handle case when there's no lastFileInstant
- Add a test case to verify scenario

Signed-off-by: Nana-EC <nana.essilfie-conduah@hedera.com>
…om TokenClient (#2423)

* Remove setting transactionMemo in TransactionSuppliers
* Remove setting expirationTime in TokenClient

Signed-off-by: Ian Jungmann <ian.jungmann@hedera.com>
- replace the one-time verifyDbConnection with on-demand transaction result & type loading

Signed-off-by: Xin Li <xin.li@hedera.com>
- add a db migration script to add the missing token account associations

Signed-off-by: Xin Li <xin.li@hedera.com>
@steven-sheehy steven-sheehy added enhancement Type: New feature P1 process Build or test related tasks labels Aug 23, 2021
@steven-sheehy steven-sheehy added this to the Mirror 0.39.0 milestone Aug 23, 2021
@steven-sheehy steven-sheehy requested a review from a team August 23, 2021 14:27
@steven-sheehy steven-sheehy self-assigned this Aug 23, 2021
@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #2441 (1aedc0e) into release/0.39 (b8c4836) will increase coverage by 6.33%.
The diff coverage is 98.36%.

❗ Current head 1aedc0e differs from pull request most recent head 37f12fc. Consider uploading reports for the commit 37f12fc to get more accurate results
Impacted file tree graph

@@                Coverage Diff                 @@
##             release/0.39    #2441      +/-   ##
==================================================
+ Coverage           84.49%   90.83%   +6.33%     
- Complexity           2346     2432      +86     
==================================================
  Files                 441      420      -21     
  Lines               12073    11593     -480     
  Branches             1029     1013      -16     
==================================================
+ Hits                10201    10530     +329     
+ Misses               1554      732     -822     
- Partials              318      331      +13     
Impacted Files Coverage Δ
...or/monitor/expression/ExpressionConverterImpl.java 94.80% <ø> (ø)
...r/properties/ScenarioPropertiesAggregatorImpl.java 100.00% <ø> (ø)
.../hedera/mirror/monitor/publish/PublishMetrics.java 85.36% <ø> (ø)
...ror/monitor/publish/PublishScenarioProperties.java 94.11% <ø> (ø)
...sh/generator/ConfigurableTransactionGenerator.java 100.00% <ø> (ø)
...r/monitor/publish/transaction/TransactionType.java 100.00% <ø> (ø)
...tion/account/AccountDeleteTransactionSupplier.java 60.00% <ø> (ø)
...a/mirror/monitor/subscribe/grpc/GrpcClientSDK.java 92.30% <ø> (ø)
...tor/subscribe/rest/response/MirrorTransaction.java 83.33% <ø> (ø)
...n/java/com/hedera/mirror/monitor/util/Utility.java 86.95% <ø> (ø)
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8c4836...37f12fc. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@steven-sheehy steven-sheehy merged commit 95140be into release/0.39 Aug 23, 2021
@steven-sheehy steven-sheehy deleted the main-to-39 branch August 23, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature P1 process Build or test related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants