Fix v1.43.2 migration failure #2450
Conversation
Signed-off-by: Xin Li <xin.li@hedera.com>
xin-hedera
added
bug
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## main #2450 +/- ##
=========================================
Coverage 90.83% 90.83%
Complexity 2432 2432
=========================================
Files 420 420
Lines 11593 11593
Branches 1013 1013
=========================================
Hits 10530 10530
Misses 732 732
Partials 331 331 Continue to review full report at Codecov.
|
...porter/src/main/resources/db/migration/v1/V1.43.2__add_missing_token_account_association.sql
Show resolved
Hide resolved
| $$ language plpgsql; | ||
|
|
||
| create trigger missing_token_account_trigger after insert | ||
| on account_balance_file | ||
| execute procedure add_missing_token_account_association(); | ||
|
|
There was a problem hiding this comment.
You're modifying a migration that has already successfully ran in some environments. That's usually very bad to do. It might be fine to do here but you'll need to manually fixup the working environments or it'll complain of migration checksum mismatch.
There was a problem hiding this comment.
Was gonna say wouldn't it be cleaner to just add this in V1.43.3?
There was a problem hiding this comment.
I think since it's not yet in a GA release, might be better to fix in the same migration script and manually fix the envs which are already on v0.39.0-rc1
There was a problem hiding this comment.
The problem is V1.43.2 fails in one env but not another. So we can't just add a V1.43.3 to fix the failing env.
- change ownership of the temp table and the function in the sql script to the importer user Signed-off-by: Xin Li <xin.li@hedera.com>
Description:
This PR fixes the v1.43.2 migration issue in our k8s environment.
Related issue(s):
Fixes #2449
Notes for reviewer:
Manually tested locally with
postgres [9.6, 13.3]
and
db.usernamesame as / different thandb.ownerChecklist