Fix Java OpenAPI generation for REST API (0.39) #2451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix 400 ref bug in OpenAPI spec * Add properly named response objects for major API calls and delete additional_properties on state proofs * Add Java generation of OpenAPI spec for validation Signed-off-by: Long Nguyen <longnguyen@circle.com>
Codecov Report
@@ Coverage Diff @@
## release/0.39 #2451 +/- ##
===============================================
Coverage 90.83% 90.83%
+ Complexity 2433 2432 -1
===============================================
Files 420 420
Lines 11593 11593
Branches 1013 1013
===============================================
Hits 10530 10530
Misses 732 732
Partials 331 331 Continue to review full report at Codecov.
|
steven-sheehy
changed the title
|
Mirror gRPC / Redis is failing or something? Is this related to anything I did? |
|
I think it's just a transient error. Retrying. |
ijungmann
approved these changes
Aug 25, 2021
|
Error looks to be due to a regression in k3s 1.21.3 that is fixed in 1.21.4: k3s-io/k3s#3704. We can merge this and I'll pin the k3s version in another PR. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Long Nguyen longnguyen@circle.com
Description:
Related issue(s):
Fixes #
Notes for reviewer:
Checklist