Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non-deterministic sorting in transactions REST API #2454

Merged
merged 2 commits into from
Aug 26, 2021

Conversation

steven-sheehy
Copy link
Member

@steven-sheehy steven-sheehy commented Aug 26, 2021

Description:

  • Fix non-deterministic sorting of assessed custom fees in transactions REST API
  • Fix non-deterministic sorting of NFT transfers in transactions REST API
  • Fix non-deterministic sorting of token transfers in transactions REST API

Related issue(s):

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

…actions API

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy steven-sheehy added bug Type: Something isn't working P2 rest Area: REST API labels Aug 26, 2021
@steven-sheehy steven-sheehy added this to the Mirror 0.40.0 milestone Aug 26, 2021
@steven-sheehy steven-sheehy requested a review from a team August 26, 2021 00:45
@steven-sheehy steven-sheehy self-assigned this Aug 26, 2021
@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #2454 (055f994) into main (0ba7505) will increase coverage by 0.60%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2454      +/-   ##
============================================
+ Coverage     90.82%   91.42%   +0.60%     
+ Complexity     2432      703    -1729     
============================================
  Files           420      214     -206     
  Lines         11591     6849    -4742     
  Branches       1016      589     -427     
============================================
- Hits          10528     6262    -4266     
+ Misses          732      451     -281     
+ Partials        331      136     -195     
Impacted Files Coverage Δ
transactions.js 98.54% <0.00%> (ø)
...importer/downloader/event/EventFileDownloader.java
...rror/importer/parser/AbstractParserProperties.java
...ra/mirror/importer/domain/FileStreamSignature.java
...importer/parser/record/RecordParserProperties.java
.../mirror/importer/converter/EntityIdSerializer.java
...r/importer/converter/NullableStringSerializer.java
.../com/hedera/mirror/importer/domain/StreamType.java
...ctionhandler/TokenAssociateTransactionHandler.java
...era/mirror/importer/config/RedisConfiguration.java
... and 197 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ba7505...055f994. Read the comment docs.

@steven-sheehy steven-sheehy changed the title Fix non-deterministic nft transfers and assessed custom fees Fix non-deterministic sorting in transactions REST API Aug 26, 2021
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@sonarcloud
Copy link

sonarcloud bot commented Aug 26, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 2e2dd66 into main Aug 26, 2021
@steven-sheehy steven-sheehy deleted the non-deterministic-transfers branch August 26, 2021 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working P2 rest Area: REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants