-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Rosetta to hard coded default configuration #2484
Conversation
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
Codecov Report
@@ Coverage Diff @@
## main #2484 +/- ##
============================================
+ Coverage 91.57% 91.99% +0.42%
+ Complexity 2536 1722 -814
============================================
Files 420 266 -154
Lines 11598 7309 -4289
Branches 1018 859 -159
============================================
- Hits 10621 6724 -3897
+ Misses 645 386 -259
+ Partials 332 199 -133 Continue to review full report at Codecov.
|
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
Move Rosetta application defaults from external
config/application.yml
to code-based configuration. This fixes Rosetta deployments not being able to start unless the external file is in the working directory of the executable.Related issue(s):
Notes for reviewer:
Checklist