Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Rosetta to hard coded default configuration #2484

Merged
merged 2 commits into from
Sep 7, 2021

Conversation

steven-sheehy
Copy link
Member

@steven-sheehy steven-sheehy commented Sep 4, 2021

Description:
Move Rosetta application defaults from external config/application.yml to code-based configuration. This fixes Rosetta deployments not being able to start unless the external file is in the working directory of the executable.

Related issue(s):

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy steven-sheehy added bug Type: Something isn't working P1 rosetta Area: Rosetta API labels Sep 4, 2021
@steven-sheehy steven-sheehy added this to the Mirror 0.40.0 milestone Sep 4, 2021
@steven-sheehy steven-sheehy requested a review from a team September 4, 2021 01:18
@steven-sheehy steven-sheehy self-assigned this Sep 4, 2021
@codecov
Copy link

codecov bot commented Sep 4, 2021

Codecov Report

Merging #2484 (1160506) into main (e975816) will increase coverage by 0.42%.
The diff coverage is n/a.

❗ Current head 1160506 differs from pull request most recent head c3f0fb8. Consider uploading reports for the commit c3f0fb8 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2484      +/-   ##
============================================
+ Coverage     91.57%   91.99%   +0.42%     
+ Complexity     2536     1722     -814     
============================================
  Files           420      266     -154     
  Lines         11598     7309    -4289     
  Branches       1018      859     -159     
============================================
- Hits          10621     6724    -3897     
+ Misses          645      386     -259     
+ Partials        332      199     -133     
Impacted Files Coverage Δ
.../importer/parser/record/entity/EntityListener.java 42.85% <0.00%> (-42.86%) ⬇️
.../com/hedera/mirror/monitor/ScenarioProperties.java
...a/mirror/grpc/service/TopicMessageServiceImpl.java
.../com/hedera/mirror/monitor/OperatorProperties.java
...r/monitor/publish/generator/ScenarioException.java
...nsaction/token/TokenDeleteTransactionSupplier.java
...on/schedule/ScheduleCreateTransactionSupplier.java
...tion/account/AccountCreateTransactionSupplier.java
.../app/services/construction/construction_service.go
...dera-mirror-rosetta/app/persistence/block/block.go
... and 144 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e975816...c3f0fb8. Read the comment docs.

@steven-sheehy steven-sheehy marked this pull request as draft September 4, 2021 01:53
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@steven-sheehy steven-sheehy marked this pull request as ready for review September 4, 2021 03:27
Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 688705f into main Sep 7, 2021
@steven-sheehy steven-sheehy deleted the rosetta-config branch September 7, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working P1 rosetta Area: Rosetta API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants