Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix importer workflow timing out #2501

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Conversation

steven-sheehy
Copy link
Member

@steven-sheehy steven-sheehy commented Sep 7, 2021

Description:

  • Add a .mvn/jvm.config to configure default JVM build settings
  • Add a .mvn/maven.config to configure default Maven build parameters
  • Add --threads 1C to support building modules in parallel
  • Change artifact concurrency from 5 threads to 10 threads
  • Change artifact provider from lightweight to httpclient for better retry configurability
  • Change artifact read timeout from 30 min to 10 s
  • Change artifact retries from 3 to 5 attempts
  • Change build max heap size from 512M to 4096M
  • Change connection TTL to 2m to workaround idle connections not closed properly in Azure

Related issue(s):

Notes for reviewer:
Using a parallel build improves ./mvnw verify runtime from 11 minutes to 8 minutes on my machine.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@steven-sheehy steven-sheehy added bug Type: Something isn't working P1 process Build or test related tasks labels Sep 7, 2021
@steven-sheehy steven-sheehy added this to the Mirror 0.40.0 milestone Sep 7, 2021
@steven-sheehy steven-sheehy self-assigned this Sep 7, 2021
@codecov
Copy link

codecov bot commented Sep 7, 2021

Codecov Report

Merging #2501 (26c441f) into main (23c0912) will increase coverage by 0.03%.
The diff coverage is 100.00%.

❗ Current head 26c441f differs from pull request most recent head 05a8cc0. Consider uploading reports for the commit 05a8cc0 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2501      +/-   ##
============================================
+ Coverage     91.51%   91.55%   +0.03%     
+ Complexity     2527     2526       -1     
============================================
  Files           421      421              
  Lines         11709    11741      +32     
  Branches       1018     1018              
============================================
+ Hits          10716    10749      +33     
+ Misses          649      648       -1     
  Partials        344      344              
Impacted Files Coverage Δ
...hedera/mirror/monitor/publish/PublishScenario.java 83.33% <100.00%> (ø)
hedera-mirror-rosetta/cmd/config.go 86.11% <100.00%> (+16.11%) ⬆️
...a/mirror/grpc/listener/CompositeTopicListener.java 80.00% <0.00%> (-4.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23c0912...05a8cc0. Read the comment docs.

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@steven-sheehy steven-sheehy marked this pull request as ready for review September 7, 2021 21:56
Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit af45ee4 into main Sep 7, 2021
@steven-sheehy steven-sheehy deleted the fix-importer-workflow branch September 7, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working P1 process Build or test related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maven Connection timed out
3 participants