Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PodDisruptionBudget change to policy/v1 #2515

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Conversation

steven-sheehy
Copy link
Member

@steven-sheehy steven-sheehy commented Sep 9, 2021

Description:

  • Bump hedera-protobuf to 0.18.0-alpha.3
  • Revert back to policy/v1beta1 for PodDisruptionBudget

Related issue(s):

Notes for reviewer:
policy/v1 not available until Kubernetes 1.21 and the latest Kubernetes that's available in our GKE release channel is 1.20.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy steven-sheehy added bug Type: Something isn't working P1 regression labels Sep 9, 2021
@steven-sheehy steven-sheehy added this to the Mirror 0.41.0 milestone Sep 9, 2021
@steven-sheehy steven-sheehy requested a review from a team September 9, 2021 22:17
@steven-sheehy steven-sheehy self-assigned this Sep 9, 2021
@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #2515 (e0c2a75) into main (8c5ab8f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #2515   +/-   ##
=========================================
  Coverage     91.59%   91.59%           
  Complexity     2551     2551           
=========================================
  Files           424      424           
  Lines         11825    11825           
  Branches       1026     1026           
=========================================
  Hits          10831    10831           
  Misses          651      651           
  Partials        343      343           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c5ab8f...e0c2a75. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Sep 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@steven-sheehy steven-sheehy merged commit 3bfaf38 into main Sep 9, 2021
@steven-sheehy steven-sheehy deleted the revert-pdb-v1 branch September 9, 2021 22:30
steven-sheehy added a commit that referenced this pull request Sep 9, 2021
* Bump hedera-protobuf to 0.18.0-alpha.3
* Revert back to policy/v1beta1 for PodDisruptionBudget

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
steven-sheehy added a commit that referenced this pull request Sep 9, 2021
* Bump hedera-protobuf to 0.18.0-alpha.3
* Revert back to policy/v1beta1 for PodDisruptionBudget

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working P1 regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants