Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version replace for rest packages (v0.40) #2520

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

Nana-EC
Copy link
Contributor

@Nana-EC Nana-EC commented Sep 10, 2021

Signed-off-by: Nana-EC nana.essilfie-conduah@hedera.com

Description:
When the rest packages were changed from hedera-mirror to @hashgraph the replacement logic was broken.

  • Update replace regex to use @hashgraph

Related issue(s):

Fixes #

Notes for reviewer:
Ran locally to verify replacement
Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Nana-EC <nana.essilfie-conduah@hedera.com>
@Nana-EC Nana-EC added bug Type: Something isn't working P1 process Build or test related tasks labels Sep 10, 2021
@Nana-EC Nana-EC added this to the Mirror 0.40.0 milestone Sep 10, 2021
@Nana-EC Nana-EC requested a review from a team September 10, 2021 15:29
@Nana-EC Nana-EC self-assigned this Sep 10, 2021
@codecov
Copy link

codecov bot commented Sep 10, 2021

Codecov Report

Merging #2520 (26ded42) into release/0.40 (809d9c7) will not change coverage.
The diff coverage is n/a.

❗ Current head 26ded42 differs from pull request most recent head c42a84e. Consider uploading reports for the commit c42a84e to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             release/0.40    #2520   +/-   ##
===============================================
  Coverage           91.59%   91.59%           
+ Complexity           2552     2551    -1     
===============================================
  Files                 424      424           
  Lines               11825    11825           
  Branches             1026     1026           
===============================================
  Hits                10831    10831           
  Misses                651      651           
  Partials              343      343           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 809d9c7...c42a84e. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Sep 10, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Nana-EC Nana-EC merged commit 06dd1fc into release/0.40 Sep 10, 2021
@Nana-EC Nana-EC deleted the rest-replace-v0.40 branch September 10, 2021 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working P1 process Build or test related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants