Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom network in rosetta bdd client #3110

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Support custom network in rosetta bdd client #3110

merged 2 commits into from
Jan 7, 2022

Conversation

xin-hedera
Copy link
Collaborator

Description:

This PR adds network nodes customization support to the rosetta bdd test client

  • Add a server network configuration to customize nodes for the main network
  • Simplify configuration parsing for rosetta server
  • Update bdd test client README

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@xin-hedera
support network nodes customization for the bdd-client
bd35bc4 
Signed-off-by: Xin Li <xin.li@hedera.com>
@xin-hedera
update doc and simplify rosetta config
3348f5c 
Signed-off-by: Xin Li <xin.li@hedera.com>
@xin-hedera xin-hedera added enhancement Type: New feature P3 test Test infrastructure, automated tests required, etc rosetta Area: Rosetta API labels Jan 7, 2022
@xin-hedera xin-hedera added this to the 0.49.0 milestone Jan 7, 2022
@xin-hedera xin-hedera requested a review from a team January 7, 2022 18:00
@xin-hedera xin-hedera self-assigned this Jan 7, 2022
@codecov
Copy link

codecov bot commented Jan 7, 2022 •
edited
Loading

Codecov Report

Merging #3110 (3348f5c) into main (4e3bbef) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #3110   +/-   ##
=========================================
  Coverage     88.23%   88.23%           
  Complexity     2393     2393           
=========================================
  Files           483      483           
  Lines         13494    13494           
  Branches       1227     1227           
=========================================
  Hits          11906    11906           
  Misses         1276     1276           
  Partials        312      312
Impacted Files Coverage Δ
hedera-mirror-rosetta/app/config/types.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e3bbef...3348f5c. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jan 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

steven-sheehy
steven-sheehy approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xin-hedera xin-hedera merged commit bcce282 into main Jan 7, 2022
@xin-hedera xin-hedera deleted the rosetta-bdd-client-custom-network branch January 7, 2022 22:42
@xin-hedera xin-hedera mentioned this pull request Jan 11, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-sheehy steven-sheehy steven-sheehy approved these changes

@ijungmann ijungmann ijungmann approved these changes

Assignees

@xin-hedera xin-hedera

Labels
enhancement Type: New feature P3 rosetta Area: Rosetta API test Test infrastructure, automated tests required, etc
Projects
None yet
Milestone
0.49.0
Development

Successfully merging this pull request may close these issues.
3 participants
@xin-hedera @steven-sheehy @ijungmann