Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump hedera-protobufs from 0.23.0-alpha.2 to 0.23.1 #3299

Merged
merged 2 commits into from
Feb 15, 2022
Merged

Conversation

steven-sheehy
Copy link
Member

@steven-sheehy steven-sheehy commented Feb 15, 2022

Description:

  • Bump hedera-protobufs from 0.23.0-alpha.2 to 0.23.1
  • Fix codecov notifying/commenting before all reports are uploaded
  • Exclude domain POJOs from code coverage

Related issue(s):

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy steven-sheehy added the dependencies Type: Pull requests that update a dependency file label Feb 15, 2022
@steven-sheehy steven-sheehy added this to the 0.51.0 milestone Feb 15, 2022
@steven-sheehy steven-sheehy requested a review from a team February 15, 2022 00:35
@steven-sheehy steven-sheehy self-assigned this Feb 15, 2022
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #3299 (657cf5f) into main (ea2fb4a) will increase coverage by 5.19%.
The diff coverage is n/a.

❗ Current head 657cf5f differs from pull request most recent head 24ba227. Consider uploading reports for the commit 24ba227 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3299      +/-   ##
============================================
+ Coverage     88.17%   93.36%   +5.19%     
+ Complexity     2508     1003    -1505     
============================================
  Files           502      294     -208     
  Lines         14143     8738    -5405     
  Branches       1306      842     -464     
============================================
- Hits          12470     8158    -4312     
+ Misses         1365      441     -924     
+ Partials        308      139     -169     
Impacted Files Coverage Δ
...ransactionhandler/TokenBurnTransactionHandler.java
...ctionhandler/SystemUndeleteTransactionHandler.java
.../record/entity/notify/NotifyingEntityListener.java
.../parser/record/entity/EntityBatchCleanupEvent.java
...rror/common/domain/transaction/CryptoTransfer.java
...eader/balance/line/AccountBalanceLineParserV1.java
...ansactionhandler/FileAppendTransactionHandler.java
...porter/reader/balance/BalanceFileReaderImplV1.java
.../java/com/hedera/mirror/importer/util/Utility.java
...er/downloader/event/EventDownloaderProperties.java
... and 198 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea2fb4a...24ba227. Read the comment docs.

Nana-EC
Nana-EC previously approved these changes Feb 15, 2022
xin-hedera
xin-hedera previously approved these changes Feb 15, 2022
Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy steven-sheehy changed the title Bump hedera-protobufs from 0.23.0-alpha.2 to 0.23.0 Bump hedera-protobufs from 0.23.0-alpha.2 to 0.23.1 Feb 15, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@steven-sheehy steven-sheehy merged commit e10b457 into main Feb 15, 2022
@steven-sheehy steven-sheehy deleted the proto-23 branch February 15, 2022 17:31
matheus-dallrosa pushed a commit that referenced this pull request Feb 18, 2022
* Bump hedera-protobufs from 0.23.0-alpha.2 to 0.23.1
* Fix codecov notifying/commenting before all reports are uploaded
* Exclude domain POJOs from code coverage

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
Signed-off-by: Matheus DallRosa <matheus.dallrosa@swirlds.com>
matheus-dallrosa pushed a commit that referenced this pull request Feb 21, 2022
* Bump hedera-protobufs from 0.23.0-alpha.2 to 0.23.1
* Fix codecov notifying/commenting before all reports are uploaded
* Exclude domain POJOs from code coverage

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
Signed-off-by: Matheus DallRosa <matheus.dallrosa@swirlds.com>
matheus-dallrosa pushed a commit that referenced this pull request Feb 21, 2022
* Bump hedera-protobufs from 0.23.0-alpha.2 to 0.23.1
* Fix codecov notifying/commenting before all reports are uploaded
* Exclude domain POJOs from code coverage

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
Signed-off-by: Matheus DallRosa <matheus.dallrosa@swirlds.com>
matheus-dallrosa pushed a commit that referenced this pull request Feb 22, 2022
* Bump hedera-protobufs from 0.23.0-alpha.2 to 0.23.1
* Fix codecov notifying/commenting before all reports are uploaded
* Exclude domain POJOs from code coverage

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
Signed-off-by: Matheus DallRosa <matheus.dallrosa@swirlds.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Type: Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants