Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround CREATE2 invalid contract ID issue (0.51) #3336

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

steven-sheehy
Copy link
Member

Description:
Cherry pick of #3335 to release/0.51

  • Workaround CREATE2 contract call invalid ID issue by re-encoding the shard.realm.num as an EVM address and looking it up in the database
  • Workaround CREATE2 contract create invalid ID issue by falling back to the root contract ID

Related issue(s):

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

* Workaround CREATE2 contract call invalid ID issue by re-encoding the shard.realm.num as an EVM address and looking it up in the database
* Workaround CREATE2 contract create invalid ID issue by falling back to the root contract ID

Signed-off-by: Steven Sheehy <steven.sheehy@hedera.com>
@steven-sheehy steven-sheehy added bug Type: Something isn't working P1 parser Area: File parsing labels Feb 25, 2022
@steven-sheehy steven-sheehy added this to the 0.51.1 milestone Feb 25, 2022
@steven-sheehy steven-sheehy requested a review from a team February 25, 2022 22:01
@steven-sheehy steven-sheehy self-assigned this Feb 25, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #3336 (9df4ded) into release/0.51 (4ce66f5) will decrease coverage by 0.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@                Coverage Diff                 @@
##             release/0.51    #3336      +/-   ##
==================================================
- Coverage           92.33%   92.31%   -0.02%     
- Complexity           2419     2428       +9     
==================================================
  Files                 454      454              
  Lines               13367    13393      +26     
  Branches             1289     1293       +4     
==================================================
+ Hits                12342    12364      +22     
- Misses                723      725       +2     
- Partials              302      304       +2     
Impacted Files Coverage Δ
...andler/AbstractContractCallTransactionHandler.java 94.87% <88.88%> (-1.68%) ⬇️
...ava/com/hedera/mirror/common/util/DomainUtils.java 82.29% <100.00%> (+1.18%) ⬆️
...rror/grpc/listener/SharedPollingTopicListener.java 90.00% <0.00%> (-4.00%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ce66f5...9df4ded. Read the comment docs.

Copy link
Collaborator

@xin-hedera xin-hedera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@steven-sheehy steven-sheehy merged commit 59d8cd0 into release/0.51 Feb 25, 2022
@steven-sheehy steven-sheehy deleted the create2-logs-51 branch February 25, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working P1 parser Area: File parsing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants