Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restjava Topics Metadata API ingress path type #8477

Conversation

xin-hedera
Copy link
Collaborator

@xin-hedera xin-hedera commented Jun 5, 2024

Description:

This PR fixes restjava Topics Metadata API ingress path type

  • Change restjava Topics Metadata API ingress path type to Exact

Related issue(s):

Fixes #8476

Notes for reviewer:

I have already manually applied the fix to previewnet.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Xin Li <xin@swirldslabs.com>
@xin-hedera xin-hedera self-assigned this Jun 5, 2024
@xin-hedera xin-hedera added this to the 0.107.0 milestone Jun 5, 2024
@xin-hedera xin-hedera added bug Type: Something isn't working rest-java Area: Java REST API labels Jun 5, 2024
@xin-hedera xin-hedera requested a review from a team June 5, 2024 19:47
@xin-hedera xin-hedera marked this pull request as ready for review June 5, 2024 19:47
Copy link
Contributor

@edwin-greene edwin-greene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link

sonarcloud bot commented Jun 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@jascks jascks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jnels124 jnels124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.49%. Comparing base (41ccc24) to head (189bd73).

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #8477   +/-   ##
=========================================
  Coverage     92.49%   92.49%           
  Complexity     7268     7268           
=========================================
  Files           884      884           
  Lines         29236    29236           
  Branches       3580     3580           
=========================================
  Hits          27042    27042           
  Misses         1382     1382           
  Partials        812      812           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xin-hedera xin-hedera merged commit 40d50a7 into main Jun 5, 2024
31 checks passed
@xin-hedera xin-hedera deleted the 8476-topic-metadata-api-ingress-path-conflicts-with-other-topic-endpoints-in-js-rest-api branch June 5, 2024 20:05
xin-hedera added a commit that referenced this pull request Jun 5, 2024
- Change restjava Topics Metadata API ingress path type to Exact

Signed-off-by: Xin Li <xin@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working rest-java Area: Java REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Topics Metadata API ingress path conflicts with other topic endpoints in JS REST API
4 participants