Add canonical test scenarios to RecordFileParserPerformanceTest
#8855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com>
steven-sheehy
added
enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8855 +/- ##
============================================
- Coverage 92.20% 92.19% -0.02%
Complexity 7598 7598
============================================
Files 925 925
Lines 30423 30430 +7
Branches 3704 3707 +3
============================================
+ Hits 28052 28054 +2
- Misses 1545 1549 +4
- Partials 826 827 +1 ☔ View full report in Codecov by Sentry. |
steven-sheehy
changed the title
RecordFileParserPerformanceTest
Signed-off-by: Steven Sheehy <steven.sheehy@swirldslabs.com>
|
steven-sheehy
requested review from
a team and
edwin-greene
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
RecordFileParserPerformanceTestRecordFileBuilderandRecordItemBuilderRecordItemBuildersyntheticContractResultsin tests by defaultRecordFileBuilderintoRecordItemBuilder.Builder.build()so timestamp, transactionID, sequenceNumber, etc get increased automaticallyRelated issue(s):
Fixes #8700
Notes for reviewer:
Checklist