Rosetta return generic unknown operation type for future transaction types #9030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xin Li <xin@swirldslabs.com>
Signed-off-by: Xin Li <xin@swirldslabs.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9030 +/- ##
============================================
+ Coverage 92.12% 92.14% +0.02%
- Complexity 7637 7651 +14
============================================
Files 929 929
Lines 30567 30608 +41
Branches 3731 3733 +2
============================================
+ Hits 28159 28204 +45
+ Misses 1572 1569 -3
+ Partials 836 835 -1 ☔ View full report in Codecov by Sentry. |
- remove btcd/btcec override - remove tiff override Signed-off-by: Xin Li <xin@swirldslabs.com>
Signed-off-by: Xin Li <xin@swirldslabs.com>
xin-hedera
dismissed stale reviews from mgoelswirlds, edwin-greene, jnels124, and steven-sheehy
via
83cd242
xin-hedera
commented
Aug 15, 2024
xin-hedera
commented
Aug 15, 2024
xin-hedera
commented
Aug 15, 2024
|
steven-sheehy
approved these changes
Aug 15, 2024
edwin-greene
approved these changes
Aug 16, 2024
xin-hedera
deleted the
8320-rosetta-return-generic-unknown-operation-type-for-future-hapi-transaction-types
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR improves Rosetta to return
UNKNOWNas transaction type for new HAPI transactionsUNKNOWNUNKNOWNoperation typego-ethereumto v1.14.8 and removebtcdversion overridetiffversion overrideRelated issue(s):
Fixes #8320
Notes for reviewer:
Checklist