Fixing admin_key rest example in the design #9063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mgoelswirlds <mugdha.goel@swirldslabs.com>
steven-sheehy
added
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9063 +/- ##
=========================================
Coverage 92.20% 92.20%
Complexity 7706 7706
=========================================
Files 933 933
Lines 30771 30771
Branches 3750 3750
=========================================
Hits 28371 28371
Misses 1562 1562
Partials 838 838 ☔ View full report in Codecov by Sentry. |
Signed-off-by: mgoelswirlds <mugdha.goel@swirldslabs.com>
Signed-off-by: mgoelswirlds <mugdha.goel@swirldslabs.com>
mgoelswirlds
commented
Aug 19, 2024
Signed-off-by: mgoelswirlds <mugdha.goel@swirldslabs.com>
steven-sheehy
approved these changes
Aug 19, 2024
|
jascks
pushed a commit
that referenced
this pull request
Aug 22, 2024
The rest example in the dynamic address book displayed a wrong admin_key. This PR fixes that. --------- Signed-off-by: mgoelswirlds <mugdha.goel@swirldslabs.com> Signed-off-by: Jeff Schmidt <jeffrey.schmidt@swirldslabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The rest example in the dynamic address book displayed a wrong admin_key. This PR fixes that.
Related issue(s):
Fixes #
Notes for reviewer:
Checklist