Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable postgres SSL to fix random query timeout (0.112) #9178

Conversation

xin-hedera
Copy link
Collaborator

@xin-hedera xin-hedera commented Aug 28, 2024

Description:

This PR backports the fix to release/0.112

  • Disable SSL
  • Enable postgres-util container
  • Reduce postgresql work_mem to 24MB to lower memory pressue
  • Add TEST_REPORTS_DIR env variable to all testkube tests

Related issue(s):

Related to #8748
Related to #9143

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

- Disable SSL
- Enable postgres-util container
- Reduce postgresql work_mem to 24MB to lower memory pressue
- Add TEST_REPORTS_DIR env variable to all testkube tests

Signed-off-by: Xin Li <xin@swirldslabs.com>
@xin-hedera xin-hedera self-assigned this Aug 28, 2024
@xin-hedera xin-hedera added this to the 0.112.0 milestone Aug 28, 2024
@xin-hedera xin-hedera added bug Type: Something isn't working performance database Area: Database labels Aug 28, 2024
@xin-hedera xin-hedera requested a review from a team August 28, 2024 15:27
@xin-hedera xin-hedera marked this pull request as ready for review August 28, 2024 15:27
Copy link
Member

@mgoelswirlds mgoelswirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jascks jascks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Aug 28, 2024

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.20%. Comparing base (458277d) to head (3b3ebdd).
Report is 1 commits behind head on release/0.112.

Additional details and impacted files
@@               Coverage Diff                @@
##             release/0.112    #9178   +/-   ##
================================================
  Coverage            92.20%   92.20%           
  Complexity            7710     7710           
================================================
  Files                  933      933           
  Lines                30783    30783           
  Branches              3752     3752           
================================================
  Hits                 28383    28383           
  Misses                1562     1562           
  Partials               838      838           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xin-hedera xin-hedera merged commit 6efd660 into release/0.112 Aug 28, 2024
37 checks passed
@xin-hedera xin-hedera deleted the 9143-some-readonly-queries-time-out-in-citus-with-pgbouncer-pooling-112 branch August 28, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Type: Something isn't working database Area: Database performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants