-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change numbers to ids token service #287
Open
Neeharika-Sompalli
wants to merge
19
commits into
main
Choose a base branch
from
change-numbers-to-ids-token-service
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add HCS state proto Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> * Add running hash, delete EntityNumber Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> * add account and token * add account and token * add token * add tokenRelation * add some javadocs * add some javadocs * address review comments * fix missing import * address comments * address review comments * Update services/state/token/account.proto Co-authored-by: Richard Bair <rbair23@users.noreply.github.com> * Update services/state/token/account.proto Co-authored-by: Richard Bair <rbair23@users.noreply.github.com> * address some review comments * move back under services * change package name * some docs and revert java package name * revert docs * add javadocs * add javadocs * re-order the first 16 --------- Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> Co-authored-by: Michael Tinker <michael.tinker@swirldslabs.com> Co-authored-by: Richard Bair <rbair23@users.noreply.github.com>
* 265 - file proto Signed-off-by: Lev Povolotsky <lev@swirldslabs.com> * 265 - packaging Signed-off-by: Lev Povolotsky <lev@swirldslabs.com> * 265 - comments Signed-off-by: Lev Povolotsky <lev@swirldslabs.com> --------- Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
* change allowances * change allowances * change allowances * change allowances * change allowances * change allowances
* 265 - file proto Signed-off-by: Lev Povolotsky <lev@swirldslabs.com> * 265 - packaging Signed-off-by: Lev Povolotsky <lev@swirldslabs.com> * 265 - comments Signed-off-by: Lev Povolotsky <lev@swirldslabs.com> * 265 - comments fix Signed-off-by: Lev Povolotsky <lev@swirldslabs.com> --------- Signed-off-by: Lev Povolotsky <lev@swirldslabs.com>
* add missing fields and change allowance names * change to bits * address review comments * address review comments * address review comments
* Add bytecode and storage slot representations Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> * Add Nft type Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> * Add EntityNumber Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> * Use bytes instead of Int256Value Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> * Fix typo Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> * Remove superfluous Int256Value type Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> * Rename Id -> UniqueTokenId Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> * Don't store code_hash, can be cached on load Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com> --------- Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
* Added state for blocks and running hashes Signed-off-by: jasperpotts <jasperpotts@users.noreply.github.com> --------- Signed-off-by: jasperpotts <jasperpotts@users.noreply.github.com> Co-authored-by: jasperpotts <jasperpotts@users.noreply.github.com>
Neeharika-Sompalli
requested review from
netopyr,
MarcKriguerAtHedera,
iwsimon and
a team
and removed request for
a team and
MarcKriguerAtHedera
June 23, 2023 15:16
iwsimon
previously approved these changes
Jun 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.