Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the "java_package" #302

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Fix the "java_package" #302

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
135a943
fix path
Neeharika-Sompalli Aug 14, 2023
ba3a213
fix comment
Neeharika-Sompalli Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions services/state/primitives.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ package proto;
* type instead.
*/

option java_package = "com.hederahashgraph.api.proto.java.primitive";
// <<<pbj.java_package = "com.hedera.hapi.node.state.primitive">>> This comment is special code for setting PBJ Compiler java package
option java_package = "com.hederahashgraph.api.proto.java";
// <<<pbj.java_package = "com.hedera.hapi.node.state.primitives">>> This comment is special code for setting PBJ Compiler java package
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this changed to be inconsistent with every other package. We do not use plural form for package names anywhere else...

option java_multiple_files = true;

/**
Expand Down