Modifications to Block Stream based on recent work #421
+90
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<h3>Modify block service definition to allow repeated block items</h3> * Modified `PublishStreamRequest` to permit repeated block items. * Added a `SubscribeStreamResponseSet` wrapper * This works around that `oneof` does not permit `repeated` fields. * Modified `SubscribeStreamResponseSet` to have a `repeated` `BlockItem` list. <h3>Make the gRPC service modular</h3> * Modify gRPC service design. * Replace single service with four specific services for modularity Signed-off-by: Joseph Sinclair <joseph.sinclair@swirldslabs.com>
AlfredoG87
reviewed
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify block service definition to allow repeated block items
PublishStreamRequestto permit repeated block items.SubscribeStreamResponseSetwrapperoneofdoes not permitrepeatedfields.SubscribeStreamResponseSetto have arepeatedBlockItemlist.Make the gRPC service modular