Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TCK): AccountCreateTransaction #1012

Merged
merged 11 commits into from
Aug 7, 2024
Merged

fix(TCK): AccountCreateTransaction #1012

merged 11 commits into from
Aug 7, 2024

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Jul 30, 2024 •
edited by ivaylogarnev-limechain
Loading

Description:

Fix AccountCreate tck method to work with the latest version of the tck server

Related issue(s):

Fixes #1013 #893

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@0xivanov 0xivanov added the enhancement New feature or request label Jul 30, 2024
@0xivanov 0xivanov self-assigned this Jul 30, 2024
0xivanov
0xivanov commented Jul 30, 2024
View reviewed changes
Copy link
Contributor Author

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding some notes for reviewers and for myself.

key_list.go Outdated Show resolved Hide resolved
key_list.go Outdated Show resolved Hide resolved
transaction.go Outdated Show resolved Hide resolved
@0xivanov 0xivanov requested a review from gsstoykov July 30, 2024 07:03
gsstoykov
gsstoykov reviewed Jul 30, 2024
View reviewed changes
crypto.go Outdated Show resolved Hide resolved
key_list.go Outdated Show resolved Hide resolved
tck/cmd/server.go Outdated Show resolved Hide resolved
transaction.go Outdated Show resolved Hide resolved
@0xivanov 0xivanov marked this pull request as ready for review July 31, 2024 06:35
0xivanov
0xivanov commented Jul 31, 2024
View reviewed changes
tck/methods/key.go Outdated Show resolved Hide resolved
@0xivanov
chore: rebase from feat/tck
1d6bd84 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
fix: tests
31597cd 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
chore: fix failing tests
ec90ef7 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
fix: use higher abstraction of key methods
cea8098 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
chore: fix conflicts
28a33c8 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov requested review from a team as code owners August 1, 2024 09:07
@0xivanov
chore: address PR comments
1c21353 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
0xivanov
0xivanov commented Aug 1, 2024
View reviewed changes
Copy link
Contributor Author

@0xivanov 0xivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to force push the whole tck server, because the feat/tck-poc was behind 80 commits and it was a mess.

@0xivanov 0xivanov changed the base branch from feat/tck-poc to main August 1, 2024 09:20
@0xivanov
chore: fix setup method
9a121b9 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
test: unit tests
85d3fac 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
Merge branch 'main' into tck-fix-account-create
40de058
@0xivanov 0xivanov requested a review from gsstoykov August 2, 2024 11:29
@codecov Codecov
Copy link

codecov bot commented Aug 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.55%. Comparing base (ab83d71) to head (3f1d35a).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1012   +/-   ##
=======================================
  Coverage   73.54%   73.55%           
=======================================
  Files         168      168           
  Lines       23755    23755           
=======================================
+ Hits        17471    17473    +2     
+ Misses       5577     5576    -1     
+ Partials      707      706    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

gsstoykov
gsstoykov reviewed Aug 6, 2024
View reviewed changes
tck/cmd/server.go Outdated Show resolved Hide resolved
tck/methods/key_test.go Outdated Show resolved Hide resolved
tck/methods/sdk_test.go Show resolved Hide resolved
tck/param/sdk.go Show resolved Hide resolved
@0xivanov
chore: address PR comments
b87fb2e 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
fix: generate public key logic
3f1d35a 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

gsstoykov
gsstoykov approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@gsstoykov gsstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

agadzhalov
agadzhalov approved these changes Aug 7, 2024
View reviewed changes
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xivanov 0xivanov merged commit 6afafdf into main Aug 7, 2024
9 checks passed
@0xivanov 0xivanov deleted the tck-fix-account-create branch August 7, 2024 09:55
@0xivanov 0xivanov mentioned this pull request Aug 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agadzhalov agadzhalov agadzhalov approved these changes

@gsstoykov gsstoykov gsstoykov approved these changes

@SimiHunjan SimiHunjan Awaiting requested review from SimiHunjan

@rwalworth rwalworth Awaiting requested review from rwalworth rwalworth is a code owner automatically assigned from hashgraph/hedera-sdk

Assignees

@0xivanov 0xivanov

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(TCK): JSON-RPC methods for AccountCreateTransaction
3 participants
@0xivanov @agadzhalov @gsstoykov