Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TCK): Implement AccountDelete #1056

Merged
merged 2 commits into from
Sep 17, 2024
Merged

feat(TCK): Implement AccountDelete #1056

merged 2 commits into from
Sep 17, 2024

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Sep 9, 2024

Description:

Related issue(s):

Fixes #1045

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov added the enhancement New feature or request label Sep 9, 2024
@0xivanov 0xivanov self-assigned this Sep 9, 2024
@0xivanov 0xivanov requested review from a team as code owners September 9, 2024 13:45
@0xivanov 0xivanov added this to the v2.46.0 milestone Sep 11, 2024
Copy link

sonarcloud bot commented Sep 11, 2024

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.77%. Comparing base (616a07f) to head (c029aa0).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1056      +/-   ##
==========================================
+ Coverage   73.64%   73.77%   +0.13%     
==========================================
  Files         171      174       +3     
  Lines       24299    24766     +467     
==========================================
+ Hits        17894    18272     +378     
- Misses       5688     5760      +72     
- Partials      717      734      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@gsstoykov gsstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@0xivanov 0xivanov merged commit bf9315e into main Sep 17, 2024
13 checks passed
@0xivanov 0xivanov deleted the tck-account-delete branch September 17, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TCK-Go: Implement JSON-RPC methods for AccountDeleteTransaction
2 participants