fix: Add better error handling in test utils #944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #944 +/- ##
=======================================
Coverage 72.86% 72.86%
=======================================
Files 167 167
Lines 23370 23370
=======================================
Hits 17028 17028
Misses 5638 5638
Partials 704 704 ☔ View full report in Codecov by Sentry. |
gsstoykov
previously approved these changes
May 30, 2024
gsstoykov
reviewed
May 30, 2024
gsstoykov
reviewed
May 30, 2024
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
agadzhalov
reviewed
May 30, 2024
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Methods like
NewIntegrationTestEnvandCloseIntegrationTestEnvmight panic ungracefully in certain circumstances.This PR adds better error handling by adding asserts when error occures.
Related issue(s):
Fixes #943
Notes for reviewer:
Checklist