fix: Account Alias Mirror Node Queries #950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
0xivanov
commented
Jun 4, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #950 +/- ##
==========================================
+ Coverage 72.86% 72.90% +0.04%
==========================================
Files 167 167
Lines 23374 23373 -1
==========================================
+ Hits 17032 17041 +9
+ Misses 5638 5631 -7
+ Partials 704 701 -3 ☔ View full report in Codecov by Sentry. |
gsstoykov
previously approved these changes
Jun 4, 2024
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
gsstoykov
previously approved these changes
Jun 4, 2024
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
|
gsstoykov
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The mirror node does not accept der encoded account aliases. We cannot query newly created hollow account info and balanced because of this.
We should use the protobuf response in order to get the num of the account/contract and use it as parameter for the query.
Related issue(s):
Fixes #948
Notes for reviewer:
Checklist