Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HIP-904: Max Auto Associations of value -1 #980

Merged
merged 12 commits into from
Jul 10, 2024
Merged

HIP-904: Max Auto Associations of value -1 #980

merged 12 commits into from
Jul 10, 2024

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Jun 13, 2024 •
edited
Loading

Description:
This PR adds the ability to set maxAutoAssociations to -1 and adds integration tests

Related issue(s):

Fixes #962 #961

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@0xivanov 0xivanov added the enhancement New feature or request label Jun 13, 2024
@0xivanov 0xivanov self-assigned this Jun 13, 2024
@0xivanov
chore: remove unnecessary conversion
81d7ba8 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov added this to the v2.40.0 milestone Jun 13, 2024
@0xivanov
test: add integration tests
3f1d059 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
chore: clean up
b3ce903 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
chore: clean up
cd9b6b0 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov
Merge branch 'main' into hip-904-max-auto-associations-of-value--1
50aed43
@0xivanov 0xivanov marked this pull request as ready for review June 25, 2024 10:05
@0xivanov 0xivanov requested review from a team as code owners June 25, 2024 10:05
@SimiHunjan SimiHunjan modified the milestones: v2.40.0, v2.41.0 Jun 25, 2024
@0xivanov
chore: fix tests
6b42011 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov requested review from a team as code owners July 3, 2024 13:59
@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.41%. Comparing base (ac22f4f) to head (f71d392).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #980      +/-   ##
==========================================
+ Coverage   73.30%   73.41%   +0.11%     
==========================================
  Files         166      166              
  Lines       23392    23392              
==========================================
+ Hits        17148    17174      +26     
+ Misses       5554     5528      -26     
  Partials      690      690

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

0xivanov
0xivanov commented Jul 4, 2024
View reviewed changes
max_auto_associations_e2e_test.go Outdated Show resolved Hide resolved
max_auto_associations_e2e_test.go Outdated Show resolved Hide resolved
max_auto_associations_e2e_test.go Outdated Show resolved Hide resolved
0xivanov
0xivanov commented Jul 4, 2024
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
gsstoykov
gsstoykov previously approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@gsstoykov gsstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of nits and a future idea. Overall LGTM.

max_auto_associations_e2e_test.go Show resolved Hide resolved
max_auto_associations_e2e_test.go Outdated Show resolved Hide resolved
max_auto_associations_e2e_test.go Show resolved Hide resolved
@0xivanov
chore: address PR feedback
541a990 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov requested a review from gsstoykov July 5, 2024 14:14
@0xivanov
chore: add more checks
cfa15cc 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
gsstoykov
gsstoykov previously approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@gsstoykov gsstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

This was linked to issues Jul 9, 2024
Update HIP-904: AccountUpdateTransaction to allow maxAutomaticTokenAssociations value to support -1 as a valid value #962
Closed
Update HIP-904: AccountCreateTransaction to allow maxAutomaticTokenAssociations value to support -1 as a valid value #961
Closed
@0xivanov 0xivanov mentioned this pull request Jul 9, 2024
Open
agadzhalov
agadzhalov previously approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xivanov
chore: fix approve + transferFrom func
f71d392 
Signed-off-by: Ivan Ivanov <ivanivanov.ii726@gmail.com>
@0xivanov 0xivanov dismissed stale reviews from agadzhalov and gsstoykov via f71d392 July 9, 2024 12:27
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@0xivanov 0xivanov merged commit 2f9c0ff into main Jul 10, 2024
9 checks passed
@0xivanov 0xivanov deleted the hip-904-max-auto-associations-of-value--1 branch July 10, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsstoykov gsstoykov gsstoykov approved these changes

@agadzhalov agadzhalov agadzhalov left review comments

@rwalworth rwalworth Awaiting requested review from rwalworth rwalworth is a code owner automatically assigned from hashgraph/hedera-sdk

@SimiHunjan SimiHunjan Awaiting requested review from SimiHunjan SimiHunjan is a code owner automatically assigned from hashgraph/hedera-sdk-go-maintainers

@JeffreyDallas JeffreyDallas Awaiting requested review from JeffreyDallas JeffreyDallas was automatically assigned from hashgraph/release-engineering

@leninmehedy leninmehedy Awaiting requested review from leninmehedy leninmehedy was automatically assigned from hashgraph/release-engineering-managers

Assignees

@0xivanov 0xivanov

Labels
enhancement New feature or request
Projects
None yet
Milestone
v2.41.0
4 participants
@0xivanov @agadzhalov @gsstoykov @SimiHunjan