build: remove inconsistent code analysis / align with hedera-services

[jjohannes]

Description:
Addresses the following items in #1794

• Introduce Guava fix, which should be in plugin in the future
• Get rid of mergeJar("com.google.code.findbugs:jsr305")
• (Partially) Adjust the code style rules and tools to what its done in hedera-services

This removes the setups for: sonar, error prone, spotbugs. Justification:

• Spotbugs does not run as part of the pipeline, but if you run it it gives a ton of errors
• Instead of sonar, we should use codacy as we do in hedera-servcies once we have the same Gradle setup
• Error prone did not really run, because it is an annotation processor that produces warnings but all warnings were turned off with this comment (??):

    // Disable warnings because I'm tired of them :P
    options.isWarnings = false

As we also do not use (and configure) these tools in hedera-services, my suggestion is to remove them for now. We can re-introduce one of these tools later again, but then with proper configuration that checks what you want to check and that works with errors (and not warnings).

Instead, the javac linting capabilities are now configured similar to how it is done in hedera-services. As preparation for sharing this configuration in the next step (hashgraph/hedera-services#14255).

Related issue(s):

#1794 / hashgraph/hedera-services#14255

Notes for reviewer:

Checklist

• Documented (Code comments, README, etc.)
• Tested (unit, integration, etc.)

[0xivanov]

You have missed one @Var in KeyTest.java

[jjohannes]

Thanks @0xivanov - fixed.

Do you think this can be merged, or is there anything you would like to keep?

[0xivanov]

LGTM

[0xivanov]

LGTM

[0xivanov]

There are some merge conflicts, should not be very hard to fix.

[jjohannes]

I fixed the conflicts. Now you need to press the button one more time @0xivanov @rbarkerSL.

[0xivanov]

LGTM