allow mirror network to be unimplemented

hashgraph · Nov 12, 2020 · aa26da4 · aa26da4
1 parent e75bd2a
commit aa26da4
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/src/client/Client.js b/src/client/Client.js
@@ -246,9 +246,10 @@ export default class Client {
 
     /**
      * @abstract
-     * @returns {(address: string) => MirrorChannelT}
+     * @returns {((address: string) => MirrorChannelT)?}
      */
     _createMirrorNetworkChannel() {
-        throw new Error("not implemented");
+        // throw new Error("not implemented");
+        return null;
     }
 }
diff --git a/src/client/MirrorNetwork.js b/src/client/MirrorNetwork.js
@@ -9,7 +9,7 @@ import MirrorNode from "../MirrorNode.js";
  */
 export default class MirrorNetwork {
     /**
-     * @param {(address: string) => MirrorChannel} channelInitFunction
+     * @param {((address: string) => MirrorChannel)?} channelInitFunction
      */
     constructor(channelInitFunction) {
         /**
@@ -33,14 +33,20 @@ export default class MirrorNetwork {
 
         this.index = 0;
 
-        /** @type {(address: string) => MirrorChannel} */
+        /** @type {((address: string) => MirrorChannel)?} */
         this._channelInitFunction = channelInitFunction;
     }
 
     /**
      * @param {string[]} network
      */
     setMirrorNetwork(network) {
+        if (this._channelInitFunction == null) {
+            // silently fail on client boot if mirror network is not
+            // supported
+            return;
+        }
+
         this.close();
         this.network = network;
 
@@ -58,6 +64,10 @@ export default class MirrorNetwork {
      * @returns {MirrorNode}
      */
     getNextMirrorNode() {
+        if (this._channelInitFunction == null) {
+            throw new Error("mirror network not supported on browser");
+        }
+
         const node = this.network[this.index];
         this.index = (this.index + 1) % this.network.length;
         return /** @type {MirrorNode} */ (this.networkNodes.get(node));